From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44861: 27.1; [PATCH] signal in `replace-regexp-in-string' Date: Thu, 26 Nov 2020 16:41:32 +0200 Message-ID: <83d000qixv.fsf@gnu.org> References: <6F768DED-2E1B-4D06-A776-FFA162AC32AD@acm.org> <97535AF5-D542-4267-A5A9-1483C32A61AC@acm.org> <83EC926B-DE9E-48BC-8FD2-C7CB3617AD50@acm.org> <871rggs1mk.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3428"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mattiase@acm.org, larsi@gnus.org, 44861@debbugs.gnu.org, shigeru.fukaya@gmail.com To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 26 15:42:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kiITN-0000ms-GK for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 15:42:13 +0100 Original-Received: from localhost ([::1]:55394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiITM-0006WC-IC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 09:42:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiITC-0006W5-1W for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 09:42:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57142) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kiITB-0004D5-QT for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 09:42:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kiITB-0000JJ-O9 for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 09:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Nov 2020 14:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44861 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed Original-Received: via spool by 44861-submit@debbugs.gnu.org id=B44861.16064017191184 (code B ref 44861); Thu, 26 Nov 2020 14:42:01 +0000 Original-Received: (at 44861) by debbugs.gnu.org; 26 Nov 2020 14:41:59 +0000 Original-Received: from localhost ([127.0.0.1]:40455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiIT9-0000J1-I0 for submit@debbugs.gnu.org; Thu, 26 Nov 2020 09:41:59 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiIT8-0000Io-0e for 44861@debbugs.gnu.org; Thu, 26 Nov 2020 09:41:58 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43368) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiIT2-0004AA-A3; Thu, 26 Nov 2020 09:41:52 -0500 Original-Received: from [176.228.60.248] (port=4869 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kiIT1-0004gM-DN; Thu, 26 Nov 2020 09:41:52 -0500 In-Reply-To: (message from Stefan Kangas on Thu, 26 Nov 2020 05:43:29 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194337 Archived-At: > From: Stefan Kangas > Date: Thu, 26 Nov 2020 05:43:29 -0800 > Cc: 44861@debbugs.gnu.org, Shigeru Fukaya > > Lars Ingebrigtsen writes: > > > But I wonder -- would it make sense to move the entire > > replace-regexp-in-string function to C? > > Before we undertake any major changes in that direction, perhaps we > should benchmark the relevant functions on the native-comp branch? It > changes the benchmarks by quite a lot in some cases. Benchmarking is always welcome, but I don't think we should dismiss performance improvements by assuming everyone will use the natively-compiled Lisp code VSN. I'm quite sure *.elc files will be used in the observable future by many people. I also expect C code to run faster than natively-compiled Lisp, when significant implementation changes, such as those suggested by Mattias, are involved.