From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46316: 27.1; wrong horizontal scroll with truncate-lines value t Date: Sat, 13 Feb 2021 17:30:38 +0200 Message-ID: <83czx4c7dt.fsf@gnu.org> References: <86wnvds38h.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16697"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46316@debbugs.gnu.org To: ynyaaa@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 13 16:32:01 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lAwts-0004Ed-V3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Feb 2021 16:32:00 +0100 Original-Received: from localhost ([::1]:44290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAwts-0001kz-1w for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Feb 2021 10:32:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAwsz-0001Sr-S4 for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 10:31:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lAwsw-0001Ul-HQ for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 10:31:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lAwsw-0005kX-EU for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 10:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Feb 2021 15:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46316 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 46316-submit@debbugs.gnu.org id=B46316.161323025122084 (code B ref 46316); Sat, 13 Feb 2021 15:31:02 +0000 Original-Received: (at 46316) by debbugs.gnu.org; 13 Feb 2021 15:30:51 +0000 Original-Received: from localhost ([127.0.0.1]:34855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAwsl-0005k8-Fh for submit@debbugs.gnu.org; Sat, 13 Feb 2021 10:30:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAwsk-0005jw-Hn for 46316@debbugs.gnu.org; Sat, 13 Feb 2021 10:30:50 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51400) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAwsf-0001NW-8u; Sat, 13 Feb 2021 10:30:45 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2225 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lAwsY-000159-G6; Sat, 13 Feb 2021 10:30:39 -0500 In-Reply-To: <86wnvds38h.fsf@gmail.com> (ynyaaa@gmail.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199933 Archived-At: > Cc: 46316@debbugs.gnu.org > From: ynyaaa@gmail.com > Date: Sat, 13 Feb 2021 00:41:18 +0900 > > #'isearch-update tries to control the hsrcoll using > #'pos-visible-in-window-group-p. > Under the folloing conditions, it returns coordinates as if the point is > at the beginning of a virtual next line. > (1) the point is the end of the buffer. > (2) the buffer does not end with a newline. > (3) the last line is displayed in the window. > (4) the last line is truncated. > So the calculation is wrong and the hscroll becomes inappropriate. Thanks, I wasn't aware isearch called pos-visible-in-window-p. I fixed pos-visible-in-window-p on the master branch in this case, so this part of the report now works correctly. > With a different reason, if isearch started with a large hscroll and the > last match is near the beginning of a line, the hscroll becomes > inapropriate. > For example, evaluate the form below, and type 'C-s a C-s', then the > current point is hidden to the left of the window. > This is because #'isearch-update only checks whether the point is to the > right of the window and does not check whether the point is to the left > of the window. > > (let ((buf (generate-new-buffer "tmp"))) > (switch-to-buffer buf) > (setq truncate-lines t) > (insert-char ?x 100) > (save-excursion > (insert-char ?\n 100) > (insert ?a))) This now also works correctly. > Regarding image-mode, a simpler example of the bug is written as below. > The hscroll does not change when the buffer is changed. > Image display, window focus or message is not related. > > (let ((buf (generate-new-buffer "tmp"))) > (switch-to-buffer buf) > (setq truncate-lines t) > (dotimes (i 200) > (insert (format ":%03d" i)) > (when (= 0 (% (1+ i) 100)) (insert ?\n))) > (forward-char -1) > (sit-for 1) > (set-window-hscroll nil (window-hscroll)) > (save-excursion > (forward-char -100) > (insert-char ?\n 10) > )) Sorry, I don't think I follow: what exactly is the bug here? What did you expect to happen ,and what did actually happen?