From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 47060@debbugs.gnu.org, eyalsoha@gmail.com
Subject: bug#47060: mouse-1-click-follows-link double broken by 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9
Date: Thu, 11 Mar 2021 17:55:00 +0200 [thread overview]
Message-ID: <83czw5n0rv.fsf@gnu.org> (raw)
In-Reply-To: <jwvlfatoibt.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Thu, 11 Mar 2021 09:55:24 -0500)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Thu, 11 Mar 2021 09:55:24 -0500
> Cc: 47060@debbugs.gnu.org
>
> > Setting the variable mouse-1-click-follows-link to 'double was broken by
> > the commit 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 .
>
> Indeed! And since this code can be sometimes tricky to debug and tune,
> your report got me scared that I was going to have to rethink the way it
> works, but ... it was a silly mistake: I called `event-convert-list`
> with a list whose last element was not always a "basic" event,
> so we ended up comparing `down-double-mouse-1` and `double-down-mouse-1`
> and deciding these are different events.
>
> The patch below should fix it.
> I think this patch should go to `emacs-27`. Eli any objection?
No, please go ahead, and thanks.
next prev parent reply other threads:[~2021-03-11 15:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 21:02 bug#47060: mouse-1-click-follows-link double broken by 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 Eyal Soha
2021-03-10 22:31 ` Eyal Soha
2021-03-11 14:55 ` Stefan Monnier
2021-03-11 15:55 ` Eli Zaretskii [this message]
2021-03-11 17:14 ` Stefan Monnier
2021-03-12 4:10 ` Eyal Soha
2021-03-12 7:44 ` Jimmy Yuen Ho Wong
2021-03-12 16:50 ` Lars Ingebrigtsen
2021-03-12 17:38 ` Stefan Monnier
2021-03-12 19:29 ` Eli Zaretskii
2021-03-12 19:30 ` Stefan Monnier
2021-03-12 17:36 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83czw5n0rv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=47060@debbugs.gnu.org \
--cc=eyalsoha@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).