From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: 48337@debbugs.gnu.org, alex.bennee@linaro.org
Subject: bug#48337: Fwd: 28.0.50; Emacs crashing randomly (possibly minibuffer activity related)
Date: Tue, 11 May 2021 22:55:55 +0300 [thread overview]
Message-ID: <83cztx3v04.fsf@gnu.org> (raw)
In-Reply-To: <YJre0ymtvLLrPrD4@ACM> (message from Alan Mackenzie on Tue, 11 May 2021 19:45:23 +0000)
> Date: Tue, 11 May 2021 19:45:23 +0000
> Cc: Alex Bennée <alex.bennee@linaro.org>,
> 48337@debbugs.gnu.org
> From: Alan Mackenzie <acm@muc.de>
>
> > Alan, the code in nth_minibuffer and its callers is unsafe. First,
> > Fnthcdr can return nil, and then XCAR of that in nth_minibuffer
> > crashes. I fixed that now on the master branch, ....
>
> That Fnthcdr call "can't possibly" return nil, unless there's a bug
> somewhere.
Then the commentary of nth_minibuffer is outdated and should be
updated: it claims that returning nil is part of the contract.
> > Fset_buffer (nth_minibuffer (minibuf_level));
>
> This, I think, can be justified - if read_minibuf_unwind can't find the
> minibuffer it's unwinding, we've got a serious problem and ought to
> abort Emacs ASAP. Should that, perhaps, be an explicit assert?
If you want to abort, assertions is not TRT, as it will not be
compiled in an optimized build. Call emacs_abort instead.
next prev parent reply other threads:[~2021-05-11 19:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87tunasd2u.fsf@linaro.org>
2021-05-10 19:30 ` bug#48337: Fwd: 28.0.50; Emacs crashing randomly (possibly minibuffer activity related) Alex Bennée
2021-05-10 19:34 ` bug#48337: Alex Bennée
2021-05-11 2:24 ` bug#48337: Fwd: 28.0.50; Emacs crashing randomly (possibly minibuffer activity related) Eli Zaretskii
2021-05-11 6:51 ` Alex Bennée
2021-05-11 8:23 ` Alex Bennée
2021-05-11 8:54 ` Alex Bennée
2021-05-11 12:21 ` Eli Zaretskii
2021-05-11 12:54 ` Alex Bennée
2021-05-11 13:42 ` Eli Zaretskii
2021-05-11 13:47 ` Eli Zaretskii
2021-05-11 19:45 ` Alan Mackenzie
2021-05-11 19:55 ` Eli Zaretskii [this message]
2021-05-12 18:54 ` Alan Mackenzie
2021-05-13 7:54 ` martin rudalics
2021-05-13 9:52 ` Alan Mackenzie
2021-05-13 11:54 ` Alan Mackenzie
2021-05-13 12:09 ` Alan Mackenzie
2021-05-14 15:20 ` Gregory Heytings
2021-05-14 16:05 ` Eli Zaretskii
2021-05-14 17:31 ` Gregory Heytings
2021-05-14 18:19 ` Eli Zaretskii
2021-05-15 9:45 ` Gregory Heytings
2021-05-11 20:14 ` Alan Mackenzie
2021-05-11 22:07 ` Alex Bennée
2021-05-14 16:31 ` Alan Mackenzie
2021-05-14 16:52 ` Alex Bennée
2021-05-14 18:40 ` Alan Mackenzie
2021-05-14 22:35 ` Alex Bennée
2021-05-15 12:00 ` Alan Mackenzie
2021-05-16 14:24 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83cztx3v04.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=48337@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=alex.bennee@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).