From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22763: 25.1.50; Feature Request -- A faster method to obtain line number at position. Date: Thu, 20 May 2021 09:45:57 +0300 Message-ID: <83cztlq4wq.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1770"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 22763@debbugs.gnu.org To: Ben Levy Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 20 08:46:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljcRq-0000F8-2G for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 May 2021 08:46:22 +0200 Original-Received: from localhost ([::1]:57216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljcRo-0007H6-DG for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 May 2021 02:46:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljcRW-0007Gp-RI for bug-gnu-emacs@gnu.org; Thu, 20 May 2021 02:46:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49674) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ljcRW-0005ll-F1 for bug-gnu-emacs@gnu.org; Thu, 20 May 2021 02:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ljcRW-00016O-B9 for bug-gnu-emacs@gnu.org; Thu, 20 May 2021 02:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 May 2021 06:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22763 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 22763-submit@debbugs.gnu.org id=B22763.16214931574221 (code B ref 22763); Thu, 20 May 2021 06:46:02 +0000 Original-Received: (at 22763) by debbugs.gnu.org; 20 May 2021 06:45:57 +0000 Original-Received: from localhost ([127.0.0.1]:32987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljcRR-000161-H0 for submit@debbugs.gnu.org; Thu, 20 May 2021 02:45:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljcRP-00015m-O8 for 22763@debbugs.gnu.org; Thu, 20 May 2021 02:45:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49582) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljcRJ-0005dQ-FU; Thu, 20 May 2021 02:45:49 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1711 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljcRJ-0000kl-15; Thu, 20 May 2021 02:45:49 -0400 In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206924 Archived-At: > Date: Wed, 19 May 2021 23:55:27 +0000 > From: Ben Levy via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > For this section in the line-number-at-pos code: > > /* Check that POSITION is n the visible range of the buffer. */ > if (pos < BEGV || pos > ZV) > args_out_of_range (make_int (start), make_int (ZV)); > > Shouldn't the lower bound condition be pos < start instead of pos < BEGV? No, because 'start' is the _byte_ position, whereas 'pos' is the character position. So if 'start's value is BEGV_BYTE, the test above already made sure 'pos' is correct, because it makes the equivalent text of the character position. And if 'start' is BEG_BYTE, then 'pos' cannot possibly be less than the beginning of the buffer, because 'pos >= BEGV_BYTE' is a more strict condition.