From: Eli Zaretskii <eliz@gnu.org>
To: Ben Levy <blevy@protonmail.com>
Cc: 22763@debbugs.gnu.org
Subject: bug#22763: 25.1.50; Feature Request -- A faster method to obtain line number at position.
Date: Thu, 20 May 2021 09:45:57 +0300 [thread overview]
Message-ID: <83cztlq4wq.fsf@gnu.org> (raw)
In-Reply-To: <xFUa3jbV475z4XzeEurd_cgedF2aR_pusvKsDxtpmasHCNbLGNup9Py_QVKu0LIGmVFYOoI9bFoKDYgc7mfvwQ2LO4nSueM5ohUnexph68c=@protonmail.com> (bug-gnu-emacs@gnu.org)
> Date: Wed, 19 May 2021 23:55:27 +0000
> From: Ben Levy via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> For this section in the line-number-at-pos code:
>
> /* Check that POSITION is n the visible range of the buffer. */
> if (pos < BEGV || pos > ZV)
> args_out_of_range (make_int (start), make_int (ZV));
>
> Shouldn't the lower bound condition be pos < start instead of pos < BEGV?
No, because 'start' is the _byte_ position, whereas 'pos' is the
character position. So if 'start's value is BEGV_BYTE, the test above
already made sure 'pos' is correct, because it makes the equivalent
text of the character position. And if 'start' is BEG_BYTE, then
'pos' cannot possibly be less than the beginning of the buffer,
because 'pos >= BEGV_BYTE' is a more strict condition.
next prev parent reply other threads:[~2021-05-20 6:45 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 2:42 bug#22763: 25.1.50; Feature Request -- A faster method to obtain line number at position Keith David Bershatsky
2016-02-22 16:06 ` Eli Zaretskii
2021-02-07 15:07 ` Lars Ingebrigtsen
2021-02-07 15:44 ` Lars Ingebrigtsen
2021-02-07 16:07 ` Lars Ingebrigtsen
2021-02-07 17:40 ` Stefan Monnier
2021-02-07 17:45 ` Lars Ingebrigtsen
2021-02-07 18:07 ` Lars Ingebrigtsen
2021-02-07 18:09 ` Eli Zaretskii
2021-02-07 18:14 ` Lars Ingebrigtsen
2021-02-07 18:23 ` Lars Ingebrigtsen
2021-02-07 19:02 ` Eli Zaretskii
2021-02-07 19:06 ` Eli Zaretskii
2021-02-07 19:25 ` Lars Ingebrigtsen
2021-02-07 19:34 ` Lars Ingebrigtsen
2021-02-07 19:43 ` Eli Zaretskii
2021-02-07 19:42 ` Eli Zaretskii
2021-02-07 19:46 ` Lars Ingebrigtsen
2021-02-07 19:52 ` Eli Zaretskii
2021-02-07 21:52 ` Lars Ingebrigtsen
2021-02-07 21:58 ` Lars Ingebrigtsen
2021-02-08 3:34 ` Eli Zaretskii
2021-02-07 22:09 ` Philipp
2021-02-07 20:37 ` Stefan Monnier
2021-02-07 20:42 ` Lars Ingebrigtsen
2021-02-07 20:50 ` Eli Zaretskii
2021-02-07 21:36 ` Lars Ingebrigtsen
2021-02-08 15:04 ` Eli Zaretskii
2021-02-09 2:17 ` Katsumi Yamaoka
2021-02-09 7:13 ` Lars Ingebrigtsen
2021-05-19 23:55 ` Ben Levy via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-20 6:45 ` Eli Zaretskii [this message]
2021-05-20 7:27 ` Andreas Schwab
2021-05-20 7:35 ` Ben Levy via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-20 9:08 ` Eli Zaretskii
2021-05-20 9:03 ` Eli Zaretskii
2021-05-20 19:53 ` Ben Levy via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-20 20:09 ` Eli Zaretskii
2021-05-20 20:40 ` Ben Levy via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-21 5:46 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83cztlq4wq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=22763@debbugs.gnu.org \
--cc=blevy@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).