From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48478: 28.0.50; yank-from-kill-ring and kill-ring-yank-pointer Date: Fri, 21 May 2021 08:51:54 +0300 Message-ID: <83cztkocqt.fsf@gnu.org> References: <83h7j1twym.fsf@gnu.org> <874kf1yq92.fsf@mail.linkov.net> <83o8d8s1jd.fsf@gnu.org> <878s4bzt6v.fsf@mail.linkov.net> <83fsyjqwtr.fsf@gnu.org> <87h7iyn0s5.fsf@mail.linkov.net> <831ra1px7n.fsf@gnu.org> <875yzdb7vz.fsf@mail.linkov.net> <83lf89ns51.fsf@gnu.org> <87eee19o24.fsf@mail.linkov.net> <83fsyhnp2r.fsf@gnu.org> <871ra19luh.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17002"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48478@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 21 07:53:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljy5t-00047K-Eu for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 May 2021 07:53:09 +0200 Original-Received: from localhost ([::1]:50142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljy5s-0003Fk-FP for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 May 2021 01:53:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljy5m-0003FX-Gi for bug-gnu-emacs@gnu.org; Fri, 21 May 2021 01:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52261) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ljy5m-0008U1-90 for bug-gnu-emacs@gnu.org; Fri, 21 May 2021 01:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ljy5m-000287-8L for bug-gnu-emacs@gnu.org; Fri, 21 May 2021 01:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 May 2021 05:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48478 X-GNU-PR-Package: emacs Original-Received: via spool by 48478-submit@debbugs.gnu.org id=B48478.16215763248102 (code B ref 48478); Fri, 21 May 2021 05:53:02 +0000 Original-Received: (at 48478) by debbugs.gnu.org; 21 May 2021 05:52:04 +0000 Original-Received: from localhost ([127.0.0.1]:35574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljy4q-00026c-I9 for submit@debbugs.gnu.org; Fri, 21 May 2021 01:52:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljy4p-000266-1l for 48478@debbugs.gnu.org; Fri, 21 May 2021 01:52:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:32952) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljy4i-0007dL-Pn; Fri, 21 May 2021 01:51:56 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4844 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljy4i-0007qw-Bl; Fri, 21 May 2021 01:51:56 -0400 In-Reply-To: <871ra19luh.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 20 May 2021 23:44:22 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206975 Archived-At: > From: Juri Linkov > Cc: 48478@debbugs.gnu.org > Date: Thu, 20 May 2021 23:44:22 +0300 > > >> > However, I'm not sure I understand what happens when I edit the > >> > kill-ring entry before hitting RET, which gets it inserted. Is the > >> > edited entry added to the kill-ring? It looks like it isn't, because > >> > the next C-y inserts the last kill-ring entry, i.e. neither the > >> > original entry I edited nor the edited entry actually inserted. Why > >> > does the kill-ring-yank-pointer gets reset to the front of the > >> > kill-ring in this case? > >> > >> After inserting the edited entry it resets the kill-ring-yank-pointer > >> for the same reason why the kill-ring-yank-pointer gets reset > >> when a new entry gets added to the kill-ring after C-w, > >> i.e. like this line in 'kill-new': > >> > >> (setq kill-ring-yank-pointer kill-ring) > > > > I could understand that if the edited entry were added to the > > kill-ring. But it isn't is it? > > It would be unexpected when yanking the edited entry with M-y > would add it to the kill-ring as its opposite command M-w does. Why unexpected? If we document that, it wouldn't be unexpected. Once again, we could decide to either add the edited entry to kill-ring or not add it. If we don't add it, kill-ring-yank-pointer should stay at its position, which corresponds to the original entry before the editing. If we do add it, the pointer should be reset to the slot where the edited entry is. Both of these behaviors can be easily documented and will be reasonably logical and intuitive, because they are basically similar to what the old M-y did. What we do now is much harder to explain and is not intuitive, at least not according to my intuition. Does anyone else have an opinion about this?