From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50256: thing-at-mouse Date: Thu, 02 Sep 2021 21:41:06 +0300 Message-ID: <83czpqzupp.fsf@gnu.org> References: <87sfys6ubm.fsf@mail.linkov.net> <871r6a8ooe.fsf@gnus.org> <87y28i85xi.fsf@mail.linkov.net> <87k0k1o5ks.fsf@mail.linkov.net> <87ilzk6bsr.fsf@mail.linkov.net> <6dcf3191-dbb3-0c6c-2483-0fc05e9ff6e5@gmx.at> <83lf4gqyn9.fsf@gnu.org> <1a65f234-c1ee-ae95-aa05-2e3d9d1e1002@gmx.at> <8335qoqobm.fsf@gnu.org> <7c9cb0a1-b222-cb06-7e7c-7f17231faca3@gmx.at> <83pmtsp4g1.fsf@gnu.org> <831r67ph8d.fsf@gnu.org> <87tuj3bffb.fsf@gnus.org> <83y28fo1xf.fsf@gnu.org> <191e9cc6-7370-5b7d-7777-716b61e0155d@gmx.at> <83pmtrnydh.fsf@gnu.org> <158a8854-f56a-9aaa-3a14-d108e086a24c@gmx.at> <83k0jznms2.fsf@gnu.org> <87v93j9dfz.fsf@mail.linkov.net> <87y28e4ysv.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3590"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 50256@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 02 20:42:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLrfE-0000l8-Pt for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Sep 2021 20:42:16 +0200 Original-Received: from localhost ([::1]:55150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLrfD-00055w-4n for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Sep 2021 14:42:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLrf2-00055l-UP for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 14:42:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58725) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLrf0-0003F7-L1 for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 14:42:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mLrf0-0002GW-Do for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 14:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Sep 2021 18:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50256 X-GNU-PR-Package: emacs Original-Received: via spool by 50256-submit@debbugs.gnu.org id=B50256.16306080838661 (code B ref 50256); Thu, 02 Sep 2021 18:42:02 +0000 Original-Received: (at 50256) by debbugs.gnu.org; 2 Sep 2021 18:41:23 +0000 Original-Received: from localhost ([127.0.0.1]:42038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLreN-0002Fd-0V for submit@debbugs.gnu.org; Thu, 02 Sep 2021 14:41:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLreI-0002FN-8c for 50256@debbugs.gnu.org; Thu, 02 Sep 2021 14:41:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45054) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLreB-0002cm-VY; Thu, 02 Sep 2021 14:41:11 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3308 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLreB-0004px-Im; Thu, 02 Sep 2021 14:41:11 -0400 In-Reply-To: <87y28e4ysv.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 02 Sep 2021 21:28:32 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213299 Archived-At: > From: Juri Linkov > Date: Thu, 02 Sep 2021 21:28:32 +0300 > Cc: 50256@debbugs.gnu.org, larsi@gnus.org > > >> --- a/src/window.c > >> +++ b/src/window.c > >> @@ -2199,8 +2199,6 @@ DEFUN ("pos-visible-in-window-p", Fpos_visible_in_window_p, > >> posint = -1; > >> else if (!NILP (pos)) > >> posint = fix_position (pos); > >> - else if (w == XWINDOW (selected_window)) > >> - posint = PT; > >> else > >> posint = marker_position (w->pointm); > > > > I confirm this fixes the reported issues. > > Actually, whereas it fixes the reported issue, > it breaks everything else: moving point up and down > always jumps to the fixed column like goal-column, > selecting a completion from the Completions buffer > always says "No completion here", 'C-c C-c' in diff-mode > jumps to the wrong hunk, etc. Figures out, because the window's point didn't get updated yet (AFAIR, it is updated by redisplay), whereas pos-visible-in-window-p is expected to work before that. I think we need to special-case the case of the current buffer. But I'd still like to talk about the semantics of calling pos-visible-in-window-p when WINDOWS is the selected window, but the WINDOW's buffer is not the current one. Who "wins" in that case, for the purpose of the default value of position: the window or the buffer?