From: Eli Zaretskii <eliz@gnu.org>
To: Ken Brown <kbrown@cornell.edu>
Cc: larsi@gnus.org, 50043@debbugs.gnu.org
Subject: bug#50043: 28.0.50; USABLE_SIGOI undef code paths do not work correctly
Date: Wed, 17 Nov 2021 18:56:59 +0200 [thread overview]
Message-ID: <83czmyzpno.fsf@gnu.org> (raw)
In-Reply-To: <4a256b21-ec50-90f8-b472-079fa98969b2@cornell.edu> (message from Ken Brown on Wed, 17 Nov 2021 09:59:35 -0500)
> Date: Wed, 17 Nov 2021 09:59:35 -0500
> Cc: larsi@gnus.org, 50043@debbugs.gnu.org
> From: Ken Brown <kbrown@cornell.edu>
>
> > But maybe it will be better to do it the same way we
> > decrease the timeout when a timer is expected to expire before the
> > timeout: we decrease the timeout, but still remember its value, and
> > don't return from waiting before the timeout unless there really was
> > some input. This would avoid affecting unrelated features such as
> > accept-process-output.
>
> I think that's already taken care of. The timeout is recalculated on each
> iteration of the main while loop:
>
> /* Compute time from now till when time limit is up. */
> /* Exit if already run out. */
> if (wait == TIMEOUT)
> {
> if (!timespec_valid_p (now))
> now = current_timespec ();
> if (timespec_cmp (end_time, now) <= 0)
> break;
> timeout = timespec_sub (end_time, now);
> }
> else
> timeout = make_timespec (wait < TIMEOUT ? 0 : 100000, 0);
>
> My reduction of timeout to 25 msec occurs after this.
So the result will be that on systems without USABLE_SIGIO we loop
more times with shorter timeouts for select? If so, it SGTM.
next prev parent reply other threads:[~2021-11-17 16:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 11:56 bug#50043: 28.0.50; USABLE_SIGOI undef code paths do not work correctly Lars Ingebrigtsen
2021-08-13 13:16 ` Eli Zaretskii
2021-08-13 14:31 ` Lars Ingebrigtsen
2021-08-13 15:51 ` Eli Zaretskii
2021-08-14 11:52 ` Lars Ingebrigtsen
2021-11-15 15:19 ` Ken Brown
2021-11-15 17:24 ` Eli Zaretskii
2021-11-15 19:26 ` Ken Brown
2021-11-16 17:44 ` Eli Zaretskii
2021-11-16 23:06 ` Ken Brown
2021-11-17 7:41 ` Lars Ingebrigtsen
2021-11-17 14:25 ` Ken Brown
2021-11-17 13:14 ` Eli Zaretskii
2021-11-17 14:19 ` Ken Brown
2021-11-17 14:34 ` Eli Zaretskii
2021-11-17 14:59 ` Ken Brown
2021-11-17 16:56 ` Eli Zaretskii [this message]
2021-11-17 17:25 ` Ken Brown
2021-11-17 17:37 ` Eli Zaretskii
2021-11-17 17:45 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83czmyzpno.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=50043@debbugs.gnu.org \
--cc=kbrown@cornell.edu \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).