From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51821: 29.0.50; Suggest add variable or frame parameter: line-height Date: Sat, 20 Nov 2021 10:39:31 +0200 Message-ID: <83czmvte4c.fsf@gnu.org> References: <87bl2nhbyp.fsf@163.com> <83bl2nugao.fsf@gnu.org> <878rxq62qt.fsf@gnus.org> <83k0hatxjl.fsf@gnu.org> <875ysu2d18.fsf@gnus.org> <83y25pshaa.fsf@gnu.org> <874k8c8sg0.fsf@gnus.org> <83ilws16hj.fsf@gnu.org> <87wnl8qg8b.fsf@gnus.org> <83czn0123n.fsf@gnu.org> <83v90pwcab.fsf@gnu.org> <87mtm0wrdt.fsf@gnus.org> <838rxkwoz8.fsf@gnu.org> <878rxjteqc.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21463"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, tumashu@163.com, 51821@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 20 09:40:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moLuw-0005KB-PR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Nov 2021 09:40:14 +0100 Original-Received: from localhost ([::1]:43738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moLuv-0003OS-HX for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Nov 2021 03:40:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moLuk-0003O5-ST for bug-gnu-emacs@gnu.org; Sat, 20 Nov 2021 03:40:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58312) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moLuk-00006T-KG for bug-gnu-emacs@gnu.org; Sat, 20 Nov 2021 03:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moLuk-0006qR-Gl for bug-gnu-emacs@gnu.org; Sat, 20 Nov 2021 03:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Nov 2021 08:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51821 X-GNU-PR-Package: emacs Original-Received: via spool by 51821-submit@debbugs.gnu.org id=B51821.163739757726270 (code B ref 51821); Sat, 20 Nov 2021 08:40:02 +0000 Original-Received: (at 51821) by debbugs.gnu.org; 20 Nov 2021 08:39:37 +0000 Original-Received: from localhost ([127.0.0.1]:41625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moLuL-0006pe-FB for submit@debbugs.gnu.org; Sat, 20 Nov 2021 03:39:37 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moLuJ-0006pP-P0 for 51821@debbugs.gnu.org; Sat, 20 Nov 2021 03:39:36 -0500 Original-Received: from [2001:470:142:3::e] (port=32840 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moLuE-0008Te-Gt; Sat, 20 Nov 2021 03:39:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vFkbC5jnULfHEdNaFmcoyUSZDxNw/n0rB6BJgqZE08E=; b=fj4lJ0/JsJxE aiwzibbFzeA7UkhGDSSaz+OtV7C/dK/zfH9hsewvVRmSAfVbyOr9EtmI5X9ogfB1KnPzro+Ntm/Eu yL3wPJ8Rfex6Qa4dfxBvmWMdricb/FRj/OtSGm5DOGCfUyHiYM2tnGMVw0khJzWAuF9/ikJcbdzLq xOhkoaMGFncYRh1n9rpO1MrFGvhOtxBPOXEeDs8n4CBqOeio6iidCE8IrQR75BxHsy91G7sAjlEjG xzyrVSN6lKAU0eQkTRLsjPZ1pNYR2/pR1lAz5Dta+pBrWBH8O/c8Ep5opF0WeBoEcGuVi+ROEIBtw XYwOHndVubksO0/GyZTmSQ==; Original-Received: from [87.69.77.57] (port=3467 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moLuE-00041i-60; Sat, 20 Nov 2021 03:39:30 -0500 In-Reply-To: <878rxjteqc.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 20 Nov 2021 09:26:19 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220464 Archived-At: > From: Lars Ingebrigtsen > Cc: tumashu@163.com, luangruo@yahoo.com, 51821@debbugs.gnu.org > Date: Sat, 20 Nov 2021 09:26:19 +0100 > > Eli Zaretskii writes: > > > No, it should fix both. Did you try that? If you did and it didn't > > work, can you show a recipe from "emacs -Q" so I could investigate? > > No, I only tested in buffers with a monospaced font and then read the > doc string. > > > The "default font" part above is an over-simplification: it is hard to > > say something accurate enough in a single short sentence. I did try > > to explain it more in the rest of the doc string: this actually > > affects any font which some face uses for ASCII characters. > > Perhaps "default font(s)" would help. For now, all of this seems like a moot point, since the "main customer" doesn't seem to want this implementation anyway. > > The separator lines are thus a very special > > case, and if we want to solve that, we need a more focused solution. > > For example, we could not stretch the height if the face's height is > > below some threshold, on the assumption that such small fonts will > > never used to display human-readable text. > > Hm, yes, the separator lines are very special, and the :height thing is > more a hack than anything else. Perhaps we should just introduce a new > spec, like :pixel-height that allows us to specify specifically how big > the separator line should be. Shouldn't it be enough to check that the face's height is less than 2 pixels, and if so, not to enlarge the height? But again, this sounds like a moot point for now.