From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50067: Context menus Date: Thu, 25 Nov 2021 10:38:44 +0200 Message-ID: <83czmo7hpn.fsf@gnu.org> References: <87pmufb3u0.fsf@mail.linkov.net> <875ytr1vkp.fsf@mail.linkov.net> <864k8mwgzr.fsf@mail.linkov.net> <86bl2hux4y.fsf@mail.linkov.net> <86h7c0wu5r.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35813"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50067@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 25 09:40:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqAIm-00095w-3o for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Nov 2021 09:40:20 +0100 Original-Received: from localhost ([::1]:37186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqAIk-0007ws-Tl for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Nov 2021 03:40:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqAIU-0007w4-VR for bug-gnu-emacs@gnu.org; Thu, 25 Nov 2021 03:40:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44135) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqAIU-00019S-6n for bug-gnu-emacs@gnu.org; Thu, 25 Nov 2021 03:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mqAIU-000442-1k for bug-gnu-emacs@gnu.org; Thu, 25 Nov 2021 03:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Nov 2021 08:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50067 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 50067-submit@debbugs.gnu.org id=B50067.163782954315553 (code B ref 50067); Thu, 25 Nov 2021 08:40:02 +0000 Original-Received: (at 50067) by debbugs.gnu.org; 25 Nov 2021 08:39:03 +0000 Original-Received: from localhost ([127.0.0.1]:55681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqAHW-00042m-NR for submit@debbugs.gnu.org; Thu, 25 Nov 2021 03:39:03 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqAHI-000424-M0 for 50067@debbugs.gnu.org; Thu, 25 Nov 2021 03:39:01 -0500 Original-Received: from [2001:470:142:3::e] (port=33054 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqAHC-0000ZC-SL; Thu, 25 Nov 2021 03:38:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lSHga249l3NHxa3HzgatAXZ1OD4qQSSh3fmrfVwtpg0=; b=qS30ztZWGYEw hRhYW+36xurbvZ8ZJZ17MVPxrhKUQTN4OwWBuUxn6l+gOM3Au8p+c1V6c91qgTTozVyNsKSf44+QD rwji1uMVhk3hsiZ7m7ke2G24enbavlVyF9nC9nivv93qG1AvlCBM5K+Mf/ByaHgJW9UIw9/9fUSVp puCkmxUfS8uyDNH7q2cqlZA6tpgZW/p5shMYAzWoptt3P5Q+uY9dVygKIWvvpUlQZc+FZ7ey/C8ei 6L4gIx/Om3JQQVDXEzMZstNbkQ92KymO6YD+ILooo9ycNQG8ezbvZ881LOULWoLzC8Z0XBd8Wke09 hLXNavuC5EQdm8FGxYV5Qg==; Original-Received: from [87.69.77.57] (port=4223 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqAHC-0003D9-Iz; Thu, 25 Nov 2021 03:38:42 -0500 In-Reply-To: <86h7c0wu5r.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 25 Nov 2021 09:50:40 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220801 Archived-At: > From: Juri Linkov > Date: Thu, 25 Nov 2021 09:50:40 +0200 > > --- a/src/callint.c > +++ b/src/callint.c > @@ -367,7 +367,7 @@ DEFUN ("call-interactively", Fcall_interactively, Scall_interactively, 1, 3, 0, > event with parameters. */ > ptrdiff_t next_event; > for (next_event = 0; next_event < key_count; next_event++) > - if (EVENT_HAS_PARAMETERS (AREF (keys, next_event))) > + if (inhibit_mouse_event_check || EVENT_HAS_PARAMETERS (AREF (keys, next_event))) > break; > > /* Handle special starting chars `*' and `@'. Also `-'. */ > @@ -618,6 +618,7 @@ DEFUN ("call-interactively", Fcall_interactively, Scall_interactively, 1, 3, 0, > do > next_event++; > while (next_event < key_count > + && ! inhibit_mouse_event_check > && ! EVENT_HAS_PARAMETERS (AREF (keys, next_event))); > > break; Why check this condition inside the loops, rather than avoid entering the loops when the condition is right, in the first place? And please add comments there explaining the meaning of the inhibit_mouse_event_check test. Thanks.