unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: laszlomail@protonmail.com, 52558@debbugs.gnu.org
Subject: bug#52558: Option for easier typing of regexps
Date: Tue, 28 Dec 2021 22:35:19 +0200	[thread overview]
Message-ID: <83czlglb7c.fsf@gnu.org> (raw)
In-Reply-To: <867dboo4rv.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 28 Dec 2021 22:25:56 +0200)

> From: Juri Linkov <juri@linkov.net>
> Cc: laszlomail@protonmail.com,  52558@debbugs.gnu.org
> Date: Tue, 28 Dec 2021 22:25:56 +0200
> 
> >> +(defvar replace-regexp-function nil
> >> +  "Function to convert a search string to a regexp to replace.
> >> +It's bound to `isearch-regexp-function' when searching
> >> +for a string to replace.")
> >
> > The first sentence is unclear: what do you mean by "convert a search
> > string to a regexp to replace"?  What "search string" is being
> > converted to regexp, and how does "replace" enter this picture?
> 
> It has a reference to `isearch-regexp-function' that has
> a complete explanation to avoid duplication of the docstring.

I don't think this is enough.  First, the first sentence of the above
doc string doesn't have any such reference, so Apropos commands, which
show only the first sentence, will not have that reference.  And
second, the doc string of isearch-regexp-function says nothing about
replacements.

There's no need to repeat the whole story you have in
isearch-regexp-function, just to say enough for the reader to
understand what is this function about and what it is used for.

> >   It's bound to `isearch-regexp-function' when searching
> >
> > seems to be incorrect: it's isearch-regexp-function that's bound to
> > replace-regexp-function, not the other way around.
> 
> Maybe this is better:
> 
>   `isearch-regexp-function' is bound to it when searching

Yes, definitely better.





  reply	other threads:[~2021-12-28 20:35 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16 17:41 bug#52558: Option for easier typing of regexps ndame via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-17 10:07 ` Phil Sainty
2021-12-18 16:47   ` ndame via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-18  4:41 ` Richard Stallman
2021-12-19 11:56 ` Lars Ingebrigtsen
2021-12-19 13:03   ` Phil Sainty
2021-12-19 14:08     ` ndame via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-19 16:11       ` Phil Sainty
2021-12-19 15:10   ` Michael Heerdegen
2021-12-20  4:43   ` Richard Stallman
2021-12-20 19:46   ` Jim Porter
2021-12-22  4:16     ` Richard Stallman
2021-12-19 17:01 ` Juri Linkov
2021-12-19 17:39   ` ndame via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-19 17:52     ` Juri Linkov
2021-12-19 17:57       ` Juri Linkov
2021-12-19 18:38     ` Juri Linkov
2021-12-19 18:48       ` Juri Linkov
2021-12-28 19:15         ` Juri Linkov
2021-12-28 20:21           ` Eli Zaretskii
2021-12-28 20:25             ` Juri Linkov
2021-12-28 20:35               ` Eli Zaretskii [this message]
2021-12-28 20:51                 ` Juri Linkov
2021-12-29 12:32                   ` Eli Zaretskii
2021-12-29 17:17                     ` Juri Linkov
2021-12-29 18:25                       ` Eli Zaretskii
2022-01-22 14:23         ` Lars Ingebrigtsen
2022-01-22 19:01           ` Juri Linkov
2022-01-23 12:36             ` Lars Ingebrigtsen
2022-01-23 18:09               ` Juri Linkov
2022-01-23 18:29                 ` Lars Ingebrigtsen
2022-01-24 18:46                   ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83czlglb7c.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=52558@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=laszlomail@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).