From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53071: 28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms? Date: Wed, 12 Jan 2022 18:58:45 +0200 Message-ID: <83czkw6gca.fsf@gnu.org> References: <39D132B5-6B44-41F0-A618-6A68BFB5FEBF@gmail.com> <87mtk1niyj.fsf@web.de> <653D1A81-3A8F-4964-8A80-4C84F8C2A07A@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24592"; mail-complaints-to="usenet@ciao.gmane.io" Cc: p.stephani2@gmail.com, 53071@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 12 18:03:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7h1n-0006DX-Hj for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Jan 2022 18:03:15 +0100 Original-Received: from localhost ([::1]:37370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7h1m-0003m5-Ka for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Jan 2022 12:03:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7gxi-0007XN-G0 for bug-gnu-emacs@gnu.org; Wed, 12 Jan 2022 11:59:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7gxi-0002WF-6O for bug-gnu-emacs@gnu.org; Wed, 12 Jan 2022 11:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7gxi-00058R-32 for bug-gnu-emacs@gnu.org; Wed, 12 Jan 2022 11:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jan 2022 16:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53071 X-GNU-PR-Package: emacs Original-Received: via spool by 53071-submit@debbugs.gnu.org id=B53071.164200674019731 (code B ref 53071); Wed, 12 Jan 2022 16:59:02 +0000 Original-Received: (at 53071) by debbugs.gnu.org; 12 Jan 2022 16:59:00 +0000 Original-Received: from localhost ([127.0.0.1]:58836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7gxg-00058B-6x for submit@debbugs.gnu.org; Wed, 12 Jan 2022 11:59:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7gxc-00057r-LD for 53071@debbugs.gnu.org; Wed, 12 Jan 2022 11:58:59 -0500 Original-Received: from [2001:470:142:3::e] (port=51112 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7gxW-0002Uz-Ua; Wed, 12 Jan 2022 11:58:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=mO4FF7Bg8CIVw/8w5dPcbKESEeikfbCgyudFqeSUB1I=; b=AZfTIhBT3if/WnuUqQY7 u4xlVlbR1O0gyMi6N6ovh1XZ4Ohun1VJx1Zh1gdGIII0eo2yz8X/rJIE6SSDj+LepIhT1Cei7AEuo Ui6BcBELKW0EqEaBoJ6ufju2cUcYP7H6mBXWif70mWgS/WPy1RI0fj69fDZ2vfFbeY6NDiNpJAwBB P1PufurGHv8r32vJA0HnZtqcv/JRBRfAf+cVPxbFaHd04j1tMXQPK2fH2HiNKyYD5/9BR2XYzXTKF EQO5jaJ34ijD2mHkMpjfN/i0rpkQBIaux04RvcVYPDdP6r3+0+uzsM+Lym5sW8YxAgxHdF5xCv3Gd /ZSQfUkI//z7eQ==; Original-Received: from [87.69.77.57] (port=1262 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7gxW-0005cU-09; Wed, 12 Jan 2022 11:58:50 -0500 In-Reply-To: <653D1A81-3A8F-4964-8A80-4C84F8C2A07A@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 12 Jan 2022 17:03:44 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224007 Archived-At: > From: Mattias Engdegård > Date: Wed, 12 Jan 2022 17:03:44 +0100 > Cc: 53071-done@debbugs.gnu.org, Philipp , > Stefan Monnier , > Paul Pogonyshev > > >>> commit 1362a9fec4dff341a84c881ac17dbf1ee2cf82fd > >>> Author: Mattias Engdegård > >>> Date: Fri Mar 5 20:21:01 2021 +0100 > >>> > >>> Make lambda-lifting work again > >> > >> Not that again. Let's CC Mattias then. > > > > Again? In any case, that change only fixed a typo in earlier code by Stefan. More likely to be a logic error in the parent change (a350ae058cae), or in edebug. > > No, you're right, it's bug#51982 again. I've backported the fix from master, which we should have done from the beginning. Paul, I'd like to say on record that listening to you would have saved us much time. Emacs 28 is in a very good shape, and no serious problems were reported in several weeks. We could release Emacs 28.1 in a few weeks, fingers crossed. So I'm about to revert this backport, but I'm prepared to hear arguments why shouldn't I. >From my POV, the regression is very minor, and it doesn't justify such a non-trivial change in such a central place. If you think the problem is serious, I'd rather revert the change we did which produced the regression in the first place (assuming it's not too complicated). Thanks.