unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 33885@debbugs.gnu.org
Subject: bug#33885: 27.0.50; PUA character makes emacs crash
Date: Sat, 12 Feb 2022 10:57:50 +0200	[thread overview]
Message-ID: <83czjssbqp.fsf@gnu.org> (raw)
In-Reply-To: <87leyg328n.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat,  12 Feb 2022 09:42:16 +0100)

> Resent-From: Lars Ingebrigtsen <larsi@gnus.org>
> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
> Resent-CC: bug-gnu-emacs@gnu.org
> Resent-Sender: help-debbugs@gnu.org
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sat, 12 Feb 2022 09:42:16 +0100
> Cc: 33885@debbugs.gnu.org
> 
> Werner LEMBERG <wl@gnu.org> writes:
> 
> > Loading the attached file `bug.el' (containing the single PUA
> > character U+E6A3) with
> >
> >   emacs -Q bug.el
> >
> > causes a crash:
> >
> >   xdisp.c:28955:
> >     Emacs fatal error:
> >       assertion failed:
> >         it->ascent >= 0 && it->descent >= 0
> 
> (I'm going through old bug reports that unfortunately weren't resolved
> at the time.)
> 
> I vaguely recall a similar problem being fixed recently (but not with
> this specific character).  Would it be possible for you to try Emacs 28/29
> and see whether the problem is still present there?

Yes, we now do

      if (it->ascent < 0)
	it->ascent = 0;
      if (it->descent < 0)
	it->descent = 0;

so I think this assertion violation should not happen anymore.  (And
in a production build, the assertion goes away anyway.)





  reply	other threads:[~2022-02-12  8:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-27  8:54 bug#33885: 27.0.50; PUA character makes emacs crash Werner LEMBERG
2018-12-27 10:36 ` Eli Zaretskii
2018-12-27 11:33   ` Eli Zaretskii
2018-12-28  8:33   ` Werner LEMBERG
2018-12-28  9:16     ` Eli Zaretskii
2018-12-28 12:38       ` Werner LEMBERG
2018-12-28 13:30         ` Eli Zaretskii
2018-12-28 14:58           ` Werner LEMBERG
2018-12-28 15:33             ` Eli Zaretskii
2018-12-28 17:03               ` Werner LEMBERG
2018-12-28 17:06                 ` Werner LEMBERG
2018-12-28 19:15                 ` Eli Zaretskii
2022-02-12  8:42 ` Lars Ingebrigtsen
2022-02-12  8:57   ` Eli Zaretskii [this message]
2022-03-12 22:43     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83czjssbqp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=33885@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).