From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50143: 28.0.50; Various issues with `tamil-itrans' input method Date: Thu, 17 Feb 2022 19:30:40 +0200 Message-ID: <83czjl1jun.fsf@gnu.org> References: <83fsv2x7jt.fsf@gnu.org> <874k509w4k.fsf@gmail.com> <83wnhu1zob.fsf@gnu.org> <87y229pxwt.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40128"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50143@debbugs.gnu.org, rameshnedunchezian@outlook.com To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 17 18:35:03 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKkgH-000A7f-UW for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Feb 2022 18:35:02 +0100 Original-Received: from localhost ([::1]:46824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nKkgG-000898-SD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Feb 2022 12:35:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33064) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKkce-0002DZ-82 for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 12:31:17 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58731) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nKkcQ-0004lo-6e for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 12:31:13 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nKkcQ-00071A-2p for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 12:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Feb 2022 17:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50143 X-GNU-PR-Package: emacs Original-Received: via spool by 50143-submit@debbugs.gnu.org id=B50143.164511905226961 (code B ref 50143); Thu, 17 Feb 2022 17:31:02 +0000 Original-Received: (at 50143) by debbugs.gnu.org; 17 Feb 2022 17:30:52 +0000 Original-Received: from localhost ([127.0.0.1]:52628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKkcF-00070l-WA for submit@debbugs.gnu.org; Thu, 17 Feb 2022 12:30:52 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKkcB-00070R-He for 50143@debbugs.gnu.org; Thu, 17 Feb 2022 12:30:50 -0500 Original-Received: from [2001:470:142:3::e] (port=53528 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKkbx-0004f2-8S; Thu, 17 Feb 2022 12:30:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=BXbkyUHsMYK024oJEcTA3vkUGjm6kNyQCLf2qqetdNc=; b=Gpq0kQ714qFyvnprY37T uyhSCvYS3MCTEKUniaz8GcAKUGV4ooYacjO3cVgRuPYZuDQb3q4/l7BxyiiZJwQj5pFTUk9luLixl +F7hQl9ylrCpg5/C7JUlxoXEQTSo0dwBONHH5pDnw17lOOlS4QDiT5Xc9ncyW+bN1dH0pCEA+Kpu0 Wsf63vEbKUTS7iEvDfC5u+SANKnOpEsuBdg/bPVlKOu1NpSoMYVtdFgwcMEmCJ/RETOcZv/hBTMhv f5yo6lVFx0PZilUQlEPbHlEazIpUN5ak7Rev/D7l2crGjf2vJQ0SwmwTJtCm+sn409tp69J9vdBuU vGvRWAOlEgHhig==; Original-Received: from [87.69.77.57] (port=4631 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKkbw-0000DB-LF; Thu, 17 Feb 2022 12:30:32 -0500 In-Reply-To: <87y229pxwt.fsf@gmail.com> (message from Visuwesh on Thu, 17 Feb 2022 16:23:06 +0530) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227106 Archived-At: > From: Visuwesh > Cc: rameshnedunchezian@outlook.com, 50143@debbugs.gnu.org > Date: Thu, 17 Feb 2022 16:23:06 +0530 > > > 1. For your items 1 and 3, just copy indian-tml-base-table to a new > > variable, modify it to include the two missing characters and > > replace the digits with nil, add a new variable similar to > > indian-tml-itrans-v5-hash, and compute its value like we do with > > indian-tml-itrans-v5-hash, but using the new table instead of > > indian-tml-base-table. Then make a new input method, called, say, > > tamil-itrans-alt, which would use the new hash variable instead of > > indian-tml-itrans-v5-hash. Submit these changes as patches to > > lisp/language/ind-util.el and lisp/leim/quail/indian.el. > > > > Does the attached patch look okay to you? Yes, thanks. > The names of the new input methods are bad. IMO, tamil-itrans and > tamil-inscript should ideally be renamed to tamil-itrans-digits and > tamil-inscript-digits, and the new input methods should be tamil-itrans > and tamil-inscript. But I guess such a backwards incompatible change > won't fly? No, I think you can do the renaming. The change is already incompatible, because we will be changing the default input method, so it will need a NEWS entry to tell how to get back old behavior, and in that NEWS entry we can also tell users to switch to another input method. > > 2. For your item 2, submit a patch that fixes the docstring of the > > relevant input methods. > > About item 2: according to the docstring of `quail-define-package', > constructs of the form "\" should be replaced by the VAR: > > DOCSTRING is the documentation string of this package. The command > ‘describe-input-method’ shows this string while replacing the form > \ in the string by the value of VAR. That value should be a > string. For instance, the form \ is > replaced by a description about how to select a translation from a > list of candidates. > > but this is not the case, I checked the code but don't see a > substitution like this happen. Maybe this should be fixed in > `describe-input-method' instead? If you can find the problem and fix i there, fine. But fixing only a small number of input methods with patches specific to those methods is also fine. Btw, the patch is already close to the limit of what we can accept without copyright assignment, so would you like to start your legal paperwork rolling at this time, so that we could in the future accept more contributions from you? If yes, I will send you the form to fill and the instructions to go with that. Thanks.