From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: raeburn@redhat.com, 54715@debbugs.gnu.org
Subject: bug#54715: 28.0.92; crash when X server died
Date: Tue, 05 Apr 2022 15:16:10 +0300 [thread overview]
Message-ID: <83czhvened.fsf@gnu.org> (raw)
In-Reply-To: <87ilro5ohc.fsf@yahoo.com> (bug-gnu-emacs@gnu.org)
> Cc: 54715@debbugs.gnu.org
> Date: Tue, 05 Apr 2022 09:05:19 +0800
> From: Po Lu via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> > #28 0x0000000000422866 in x_connection_closed (dpy=dpy@entry=0x511fc50, error_message=error_message@entry=0x7ffde15e78e8 "Connection lost to X server ':0.0'", ioerror=ioerror@entry=true) at ../../src/xterm.c:10240
>
> x_connection_closed binds inhibit-redisplay to t, so redisplay cannot do
> anything interesting inside.
True.
> > #12 0x00000000004202a3 in redisplay_internal () at ../../src/xdisp.c:15633
>
> But this frame shows that it did try to do something, and aborted.
It looks like it aborted trying to do nothing ;-)
> Unfortunately, I don't see anything interesting at line 15633 in Emacs
> 28.
I do see something interesting (did you look in 28.0.92 sources?):
/* No redisplay if running in batch mode or frame is not yet fully
initialized, or redisplay is explicitly turned off by setting
Vinhibit_redisplay. */
if ((FRAME_INITIAL_P (SELECTED_FRAME ()) <<<<<<<<<<<<<<<<<<<<<<<<<
&& redisplay_skip_initial_frame)
|| !NILP (Vinhibit_redisplay))
return;
Crystal ball says something is wrong with SELECTED_FRAME, and that
causes the abort.
My guess would be that Ken's kill-emacs-hooks were called when the X
server died, and one of those hooks is unsafe, in that it causes
redisplay. Or maybe we should refrain from calling
redisplay_preserve_echo_area in delete-process when Emacs is shutting
down due to a fatal error?
next prev parent reply other threads:[~2022-04-05 12:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 21:19 bug#54715: 28.0.92; crash when X server died Ken Raeburn
2022-04-05 1:05 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-05 12:16 ` Eli Zaretskii [this message]
2022-04-05 12:52 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-05 19:10 ` Ken Raeburn
2022-04-05 19:24 ` Eli Zaretskii
2022-04-06 0:43 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83czhvened.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=54715@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
--cc=raeburn@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).