From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55493: [PATCH] Rename Oriya to Odia Date: Wed, 18 May 2022 15:34:11 +0300 Message-ID: <83czgbf29o.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="467"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55493@debbugs.gnu.org To: =?UTF-8?Q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0_?= =?UTF-8?Q?=E0=A4=B8=E0=A4=BF=E0=A4=82=E0=A4=B9?= Sameer Singh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 18 14:35:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nrItb-000AQp-Ek for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 May 2022 14:35:19 +0200 Original-Received: from localhost ([::1]:36398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrIta-0000VW-Bg for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 May 2022 08:35:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrItL-0000Ro-0I for bug-gnu-emacs@gnu.org; Wed, 18 May 2022 08:35:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37175) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nrItK-0008Aq-L8 for bug-gnu-emacs@gnu.org; Wed, 18 May 2022 08:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nrItK-0004gu-C1 for bug-gnu-emacs@gnu.org; Wed, 18 May 2022 08:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 May 2022 12:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55493 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55493-submit@debbugs.gnu.org id=B55493.165287728317999 (code B ref 55493); Wed, 18 May 2022 12:35:02 +0000 Original-Received: (at 55493) by debbugs.gnu.org; 18 May 2022 12:34:43 +0000 Original-Received: from localhost ([127.0.0.1]:59305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrIt0-0004gE-4I for submit@debbugs.gnu.org; Wed, 18 May 2022 08:34:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrIst-0004fx-Nf for 55493@debbugs.gnu.org; Wed, 18 May 2022 08:34:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56490) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrIsk-000858-U5; Wed, 18 May 2022 08:34:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=wTdisQocwZFTwxrdVhEnkNlnjCk58+BngTrmhmArWWw=; b=CrDFYSBwojBHYhAXIesp CEua/HVtXBRHk3yA/mv6fq+Ue2RUsrhASU2PxecoOO1/JZQFaI7Semhw1vbEWXlmw48yZ2vzM2m8P HpF0kYOkE6aUNCLB0dJZfJmM0hU08b+e3m3UUfjVMNqdoewQuWyXc11yh6bC+cu90MMh70TObHhYb Mz5xmPQa1sEvzC56RoxKgZd/ZPhq7hLlyecaIJ9sBZGo055gn0Rwv/kx0ntbVh51Z9NBkgT1qjp6V 9uxMChA1dJDIkPT26CWoF0JIzQHhYgZQxyBOfoLiS/QgHlmJV8ODID01/hQ2hEBUvVKTuQQJ/xct/ FAapurRSFqdrvg==; Original-Received: from [87.69.77.57] (port=3217 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrIsc-0003KI-G7; Wed, 18 May 2022 08:34:23 -0400 In-Reply-To: (lumarzeli30@gmail.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232551 Archived-At: > From: समीर सिंह Sameer Singh > > Date: Wed, 18 May 2022 05:26:39 +0530 > > Since Oriya was renamed to Odia in 2011. (https://legislative.gov.in/sites/default/files/A2011-15.pdf) Here is a > patch to do the same in Emacs. > > I have not changed it wherever unicode, is13194, iso639, cdac and akruti were involved, since they all use the > old name. (I am not sure about cdac though, because I was not able to run their software) > > There was also a typo in erc/erc-lang.el and lisp/ldefs-boot.el, iso639-1 was written as iso638, I fixed that. > > Please review the patch. Thanks. In general, this patch is too radical, and unnecessarily so. > * etc/HELLO: Rename Oriya to Odia. The changes to HELLO do more that the above says. I don't think I understand the reason for the change in the "South Asia" line. Also, please include the bug number in the commit log message. > -;; FIXME: It's ISO 639-1, not ISO 638. ISO 638 is for paper, board and pulps. > -;; The Lisp variable should be renamed. > - > -(defvar iso-638-languages > +(defvar iso-639-1-languages This is unrelated, and I see no reason to rename the variable in a backward-incompatible way. It's just a variable, so it doesn't have to be named rigorously correct. If we were discussing new code, the correction would have had its place, but not now, 16 years after it was introduced. > diff --git a/lisp/language/ind-util.el b/lisp/language/ind-util.el > index 60ada03fa2..dede705a30 100644 > --- a/lisp/language/ind-util.el > +++ b/lisp/language/ind-util.el > @@ -113,7 +113,7 @@ indian-gjr-base-table > (;; Inscript-extra (4) (#, $, ^, *, ]) > "્ર" "ર્" "ત્ર" "શ્ર" "઼"))) > > -(defvar indian-ori-base-table > +(defvar indian-odi-base-table I don't think we should rename variables and functions. It's just a lot of hassle for us (defalias etc.) and potentially for others, and the gain is very small. This variable doesn't even say "oriya", just "ori". Let's not be too radical here. > @@ -549,8 +549,8 @@ indian-gjr-itrans-v5-hash > (indian-make-hash indian-gjr-base-table > indian-itrans-v5-table)) > > -(defvar indian-ori-itrans-v5-hash > - (indian-make-hash indian-ori-base-table > +(defvar indian-odi-itrans-v5-hash > + (indian-make-hash indian-odi-base-table > indian-itrans-v5-table)) Likewise here (and elsewhere in similar changes). > (set-language-info-alist > - "Oriya" '((charset unicode) > - (coding-system utf-8) > - (coding-priority utf-8) > - (input-method . "oriya-itrans") > - (sample-text . "Oriya (ଓଡ଼ିଆ) ନମସ୍କାର") > - (documentation . "\ > -Such languages using Oriya script as Oriya, Khonti, and Santali > + "Odia" '((charset unicode) ;; formerly Oriya > + (coding-system utf-8) > + (coding-priority utf-8) > + (input-method . "odia-itrans") > + (sample-text . "Odia (ଓଡ଼ିଆ) ନମସ୍କାର") > + (documentation . "\ > +Such languages using Odia script as Odia, Khonti, and Santali > are supported in this language environment.")) > '("Indian")) The doc string should say that this language environment was previously named "Oriya". > diff --git a/lisp/ldefs-boot.el b/lisp/ldefs-boot.el > index 95ad2f78cf..ade3e9c69c 100644 > --- a/lisp/ldefs-boot.el > +++ b/lisp/ldefs-boot.el This file is regenerated automatically, so this part should be omitted. > diff --git a/lisp/leim/quail/indian.el b/lisp/leim/quail/indian.el > index 95798a4477..e06464dc24 100644 > --- a/lisp/leim/quail/indian.el > +++ b/lisp/leim/quail/indian.el > @@ -91,10 +91,10 @@ "\\''" > "Gujarati transliteration by ITRANS method.") > > (if nil > - (quail-define-package "oriya-itrans" "Oriya" "OriIT" t "Oriya ITRANS")) > + (quail-define-package "odia-itrans" "Odia" "OdiIT" t "Odia ITRANS")) We cannot rename an input method we had for almost 20 years. If there is some way of having an alias for an input method (I don't think so, but maybe I'm missing something), let's use that; otherwise we will have either to leave the old name alone or define a new input method that is an exact copy of the old one, except for the name and the mode-line indicator. > - /* Workaround for crash when displaying Oriya characters > + /* Workaround for crash when displaying Odia characters This is incorrect: characters are named by Unicode, and Unicode still calls that block Oriya (and will not change the name, AFAIU).