From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56317: 28.1; image-convert not working on Windows Date: Thu, 30 Jun 2022 12:59:51 +0300 Message-ID: <83czeq5v54.fsf@gnu.org> References: <827d4yoeus.fsf@gmail.com> <83edz66434.fsf@gnu.org> <82y1xemu8g.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12391"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56317@debbugs.gnu.org To: pquessev@gmail.com, Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 30 12:00:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6qy9-0002zh-G5 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Jun 2022 12:00:17 +0200 Original-Received: from localhost ([::1]:57572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6qy7-0005GU-RV for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Jun 2022 06:00:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6qxx-0005FB-7a for bug-gnu-emacs@gnu.org; Thu, 30 Jun 2022 06:00:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39038) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o6qxu-0007yY-8k for bug-gnu-emacs@gnu.org; Thu, 30 Jun 2022 06:00:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o6qxu-0004nN-5m for bug-gnu-emacs@gnu.org; Thu, 30 Jun 2022 06:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Jun 2022 10:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56317 X-GNU-PR-Package: emacs Original-Received: via spool by 56317-submit@debbugs.gnu.org id=B56317.165658319518395 (code B ref 56317); Thu, 30 Jun 2022 10:00:02 +0000 Original-Received: (at 56317) by debbugs.gnu.org; 30 Jun 2022 09:59:55 +0000 Original-Received: from localhost ([127.0.0.1]:32935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6qxm-0004mc-Vq for submit@debbugs.gnu.org; Thu, 30 Jun 2022 05:59:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6qxh-0004mJ-8O for 56317@debbugs.gnu.org; Thu, 30 Jun 2022 05:59:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46350) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6qxb-0007tx-Ri; Thu, 30 Jun 2022 05:59:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kfAhspqhxCnsaexI9MlU9870cUCoGuntiMdcJI22ecs=; b=IgvN9RyCGykV D5aE3BOVpR/X7C/U17RdWlXXQYgxPSMCVY7ak4cFxdAFzNopxtmIh5if77hBCULQ4sOugIUdXj0Q8 wUgvgzaRyTTPlcniaOx5TxQwvIfzQoB+Tw5LhWnNS7t13B921dLex8f0U/ksz3IyjvJ8bJu0ngdVs FF51WBd4F5N0WjzmsiSNOmH+Wti4Cbi+syFzeHhV3LqXN38F02W/vcgIl/Gtu6Mu52cOLT/ae9Lsf FeWZpWt9b5gb4znrzwdQV0ciW0esPOp5wQcSc70xouRUOxd6CycB27QO4lwaprnsALvyrlvYWBRSk P5JOfsbe71tv7c20Abvkxw==; Original-Received: from [87.69.77.57] (port=1315 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6qxb-0000rs-Bg; Thu, 30 Jun 2022 05:59:43 -0400 In-Reply-To: <82y1xemu8g.fsf@gmail.com> (message from Pascal Quesseveur on Thu, 30 Jun 2022 10:27:27 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235706 Archived-At: > From: Pascal Quesseveur > Cc: 56317@debbugs.gnu.org > Date: Thu, 30 Jun 2022 10:27:27 +0200 > > >"EZ" == Eli Zaretskii writes: > > EZ> Thanks. Please try the patch below: > > Thanks. Is is working fine. Thanks for testing. Lars, WDYT about including this in Emacs 28.2? If you think it's safe enough, would you mind testing the patch on GNU/Linux? I don't have access to any systems with ImageMagick installed. (In the final commit, I will make the same change in the ffmpeg method.) > I have 2 other remrks about image-converter: > > - it would be better to use 'magick convert' instead of 'convert' to > avoid ambiguities at least under windows, I don't understand: the actual method invoked in that case is image-converter--convert-magick. The image-converter--convert one (if that's what you mean) is a generic name (see that cl-defmethod?). So what is not right here? > - bmp images cannot be processed by an external converter as bmp is > listed in image-type-file-name-regexps. Except the bmp images are > not displayed by the new method on Windows Emacs 29 can display BMP images on Windows natively, so that problem is already taken care of, just not in Emacs 28.