From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56423: 29.0.50; Hi-lock in dired broken by toggling wdired-mode Date: Thu, 07 Jul 2022 13:35:10 +0300 Message-ID: <83czeh5hy9.fsf@gnu.org> References: <874jzui52r.fsf@web.de> <87iloa2hlm.fsf@web.de> <87mtdmyrp4.fsf@web.de> <83o7y15vtz.fsf@gnu.org> <87edyxz0as.fsf@web.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31519"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56423@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 07 12:36:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9Orm-0007wg-4d for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Jul 2022 12:36:14 +0200 Original-Received: from localhost ([::1]:48086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9Ork-0001UH-Mj for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Jul 2022 06:36:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35484) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9Ora-0001U9-KO for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 06:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33729) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9Ora-00074W-BP for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 06:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9Ora-0002gP-A4 for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 06:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Jul 2022 10:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56423 X-GNU-PR-Package: emacs Original-Received: via spool by 56423-submit@debbugs.gnu.org id=B56423.165719012010260 (code B ref 56423); Thu, 07 Jul 2022 10:36:02 +0000 Original-Received: (at 56423) by debbugs.gnu.org; 7 Jul 2022 10:35:20 +0000 Original-Received: from localhost ([127.0.0.1]:55859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9Oqu-0002fQ-91 for submit@debbugs.gnu.org; Thu, 07 Jul 2022 06:35:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9Oqs-0002fE-VG for 56423@debbugs.gnu.org; Thu, 07 Jul 2022 06:35:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42892) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9Oqn-0006uJ-LW; Thu, 07 Jul 2022 06:35:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mfQVKHkJ5C5XlfZFNKvn3wjHW1NO1n7UkWAxQS9dIHk=; b=p+2kYW8iC2oB mu5XjLfQ80kk1PTSUly/Q7KyT7dSPftEbbtgSaEBj5WZe75B5i/wkuL0YgH5y7MKl9XinDGqi1llf pOdGlIFP6NwwYA1J4bPLnwS2tieZhar/o+8nhs2jjyoMeqywznCNNF5XUN++uBr8odclORQo+zt8b EV++GhtGaFC/8wr85aNtjIkB8qdRr8OnTBM/raS9D7pHdHkWBflrmMCd8qSROvKDUeJD85BOvP5Yq jZ9Z6W7WU9RlX29iEDps2sfxP+tPfbyxXWGsaoef0GS98SI+DZdCt5lXatzcuDp/mEUgGLTc4Cj0U GjMHNqLDd14xZXH+TSJHkA==; Original-Received: from [87.69.77.57] (port=1652 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9Oqn-0002bL-4K; Thu, 07 Jul 2022 06:35:13 -0400 In-Reply-To: <87edyxz0as.fsf@web.de> (message from Michael Heerdegen on Thu, 07 Jul 2022 12:26:03 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236352 Archived-At: > From: Michael Heerdegen > Cc: 56423@debbugs.gnu.org > Date: Thu, 07 Jul 2022 12:26:03 +0200 > > Eli Zaretskii writes: > > > Don't we need to make sure font-lock-major-mode is restored no matter > > how wdired is exited, whether normally or abnormally? > > There are two official ways to return - `wdired-abort-changes' and > `wdired-finish-edit' - both call `wdired-change-to-dired-mode' (which I > modified). > > If a way of exiting doesn't call `wdired-change-to-dired-mode' your > dired buffer would be broken afterwards AFAIU - you must call it to get > rid of the modifications made by wdired. It sounds like you described the "normal" ways of returning? I mostly had in mind the "abnormal" ones, via one of the non-local exits. If that is possible, we should set up unwind-protect form.