From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56561: 29.0.50; Infloop in try_window Date: Fri, 15 Jul 2022 18:37:50 +0300 Message-ID: <83cze6s7xt.fsf@gnu.org> References: <874jzjwmhn.fsf@md5i.com> <83v8rzsdd1.fsf@gnu.org> <878rovxqjo.fsf@md5i.com> <83sfn2sy19.fsf@gnu.org> <83lesusl4w.fsf@gnu.org> <87lesumqgf.fsf@yahoo.com> <83ilnysbc5.fsf@gnu.org> <83fsj2s8fg.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7732"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mwd@md5i.com, 56561@debbugs.gnu.org To: luangruo@yahoo.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 15 17:39:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCNPL-0001rw-TD for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jul 2022 17:39:12 +0200 Original-Received: from localhost ([::1]:38390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oCNPK-0002ly-Tc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jul 2022 11:39:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCNPC-0002ez-CT for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2022 11:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44265) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oCNPC-0002hj-3O for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2022 11:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oCNPB-00051q-Qn for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2022 11:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jul 2022 15:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56561 X-GNU-PR-Package: emacs Original-Received: via spool by 56561-submit@debbugs.gnu.org id=B56561.165789948519256 (code B ref 56561); Fri, 15 Jul 2022 15:39:01 +0000 Original-Received: (at 56561) by debbugs.gnu.org; 15 Jul 2022 15:38:05 +0000 Original-Received: from localhost ([127.0.0.1]:42024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCNOH-00050W-0l for submit@debbugs.gnu.org; Fri, 15 Jul 2022 11:38:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCNOE-000500-7l for 56561@debbugs.gnu.org; Fri, 15 Jul 2022 11:38:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35038) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCNO6-0002ZA-Q1; Fri, 15 Jul 2022 11:37:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=klTnV9YlGaHOoL3x1A55a2190m+2x/3DP4o4C+KSZZo=; b=j4sUDpAWvVaQ eKtgQs6v634qqMdfQt3WpS+vA9yqMPu+gF5mJUNYzYxJwdJyNYHZF++RYouWybzoUE2EchiG+KEM1 WlwhveiHaDvegKlTR5VhRh57ngxzBv7d18AB6tS3g/UR3NfufpSpVACviyW0IT/YGBlypp9HubcNU DJiaLVoQSgk3ur6LZrCwJfitXJxUgz9g6Y+hvGXYX8WabZwAFZJzxEqWIJ+cQoXWBRyPKLuNHcl49 e7To5rLG/H1eDd5mmu89Q1M4AVdClK4omL/tXfGtBhY1mZKALC1kkf0m3e7pj02MNLmqpO+rrVWPr UW8ZzidH4gQOdxB6dgR6TQ==; Original-Received: from [87.69.77.57] (port=4114 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCNO6-0002iN-4W; Fri, 15 Jul 2022 11:37:54 -0400 In-Reply-To: <83fsj2s8fg.fsf@gnu.org> (message from Eli Zaretskii on Fri, 15 Jul 2022 18:27:15 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237116 Archived-At: > Cc: mwd@md5i.com, 56561@debbugs.gnu.org > Date: Fri, 15 Jul 2022 18:27:15 +0300 > From: Eli Zaretskii > > > Cc: mwd@md5i.com, 56561@debbugs.gnu.org > > Date: Fri, 15 Jul 2022 17:24:26 +0300 > > From: Eli Zaretskii > > > > > From: Po Lu > > > Cc: mwd@md5i.com, 56561@debbugs.gnu.org > > > Date: Fri, 15 Jul 2022 21:54:24 +0800 > > > > > > BTW, I have a question about the fix: redisplay cannot run when a > > > tooltip is displayed as popup menu help-text, so adjust_glyph_matrix and > > > the subsequent try_window call that is required to generate the display > > > contents will not be called in time, leading to a blank tooltip. > > > > > > The call could previously never fail, since the tooltip code specifies > > > TRY_WINDOW_IGNORE_FONTS_CHANGE. > > > > > > Would it be appropriate to call adjust_frame_glyphs and try_window again > > > if this call to try_window in Fx_show_tip fails? > > > > You mean, adjust_frame_glyphs, right? > > > > We probably should do that > > On second thought, I take this back. I don't see how we could have a > blank tooltip. We call try_window just so we could compute the size > of the text in it, which then allows us to know the size of the > tooltip. On third thought, why do we even call try_window there? The original code needed try_window because it then used the glyph matrix it produces to calculate the size of the tooltip. But we've dumped that code, and we nowadays use window-text-pixel-size instead, which emulates the display internally anyway. So I think we should simply delete the call to try_window from x-show-tip, and be done. At least on master.