From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56607: 29.0.50; (setq auto-resize-tool-bars 'grow-only) has no effect (pgtk) Date: Sun, 17 Jul 2022 08:57:37 +0300 Message-ID: <83cze4qo1a.fsf@gnu.org> References: <8b743715-5027-1802-dfc4-d56abadedf08@rhansen.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16505"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56607@debbugs.gnu.org To: Richard Hansen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 17 07:58:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCxIE-00047u-Ng for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Jul 2022 07:58:14 +0200 Original-Received: from localhost ([::1]:48666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oCxID-0002u4-Az for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Jul 2022 01:58:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCxI2-0002tv-AC for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2022 01:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48779) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oCxI2-0003T7-0x for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2022 01:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oCxI1-0006Gp-Tl for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2022 01:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Jul 2022 05:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56607 X-GNU-PR-Package: emacs Original-Received: via spool by 56607-submit@debbugs.gnu.org id=B56607.165803748024096 (code B ref 56607); Sun, 17 Jul 2022 05:58:01 +0000 Original-Received: (at 56607) by debbugs.gnu.org; 17 Jul 2022 05:58:00 +0000 Original-Received: from localhost ([127.0.0.1]:46538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCxI0-0006Ga-A9 for submit@debbugs.gnu.org; Sun, 17 Jul 2022 01:58:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCxHz-0006GO-6j for 56607@debbugs.gnu.org; Sun, 17 Jul 2022 01:57:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41778) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCxHt-0003Qf-Lp; Sun, 17 Jul 2022 01:57:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=C0EECrEUcTMksmZUXWRsWmJ7YYNb3K7JvdGe4/Tk8gE=; b=erKp0kGkXv10 UDZ+2DY6GwhH+EEJzPdImcLbQCQKsZSsKYXMj7hviocllSsdeJr+Jnd86xOaVE8bXWgpLnJs07OkE igERq/ki6MjaGilNXPfz96uTPwBOOPCZIe91bXU8U6G1L5LCL5G3uwP9dQQZTwOieOC4Waz1AacgL zfL9NtF32j4lI4w4DQOTF6mcvMmHj9ACc07ptq2vENxX5hP/mPHM7Eu0tHNkL5afdsmfOdCH8+F66 OvxrM0v0wwAge32oQTxmJ0ONNm1LQNunkFhWnqGVt2a+oG6Km9KRZ4yAaCE1O/1r9Y0gIvbmYsuO7 f70kO7HjY1IapuhQ/+yKQg==; Original-Received: from [87.69.77.57] (port=2663 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCxHs-0000Zd-Kv; Sun, 17 Jul 2022 01:57:53 -0400 In-Reply-To: <8b743715-5027-1802-dfc4-d56abadedf08@rhansen.org> (message from Richard Hansen on Sat, 16 Jul 2022 21:52:09 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237233 Archived-At: > Date: Sat, 16 Jul 2022 21:52:09 -0400 > From: Richard Hansen > > emacs -Q > M-: (setq auto-resize-tool-bars 'grow-only) RET > C-s > > The tool bar now shows a ridiculously oversized marine life ring icon on the "Help" button, and the height of the tool bar has grown to accommodate the icon's size. > > C-g > > Expected behavior: The tool bar reverts back to how it was before C-s was pressed, except its height stays the same. > > Actual behavior: The tool bar reverts back to how it was before, including reverting to its original height. I cannot reproduce this because on my system the Help button doesn't get the "ridiculously oversized marine life ring icon", so the tool bar doesn't resize. But I see something suspicious in the code which handles this feature: if (!NILP (Vauto_resize_tool_bars)) { bool change_height_p = true; <<<<<<<<<<<<<<<<<<<<<< AFAIU, that initialization should have been to 'false', not 'true'. Can you try this on your system and see if such a change gives good results? Thanks.