unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Richard Hansen <rhansen@rhansen.org>
Cc: 56607@debbugs.gnu.org
Subject: bug#56607: 29.0.50; (setq auto-resize-tool-bars 'grow-only) has no effect (pgtk)
Date: Sun, 17 Jul 2022 08:57:37 +0300	[thread overview]
Message-ID: <83cze4qo1a.fsf@gnu.org> (raw)
In-Reply-To: <8b743715-5027-1802-dfc4-d56abadedf08@rhansen.org> (message from Richard Hansen on Sat, 16 Jul 2022 21:52:09 -0400)

> Date: Sat, 16 Jul 2022 21:52:09 -0400
> From: Richard Hansen <rhansen@rhansen.org>
> 
> emacs -Q
> M-: (setq auto-resize-tool-bars 'grow-only) RET
> C-s
> 
> The tool bar now shows a ridiculously oversized marine life ring icon on the "Help" button, and the height of the tool bar has grown to accommodate the icon's size.
> 
> C-g
> 
> Expected behavior: The tool bar reverts back to how it was before C-s was pressed, except its height stays the same.
> 
> Actual behavior: The tool bar reverts back to how it was before, including reverting to its original height.

I cannot reproduce this because on my system the Help button doesn't
get the "ridiculously oversized marine life ring icon", so the tool
bar doesn't resize.  But I see something suspicious in the code which
handles this feature:

  if (!NILP (Vauto_resize_tool_bars))
    {
      bool change_height_p = true;  <<<<<<<<<<<<<<<<<<<<<<

AFAIU, that initialization should have been to 'false', not 'true'.
Can you try this on your system and see if such a change gives good
results?

Thanks.





  parent reply	other threads:[~2022-07-17  5:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-17  1:52 bug#56607: 29.0.50; (setq auto-resize-tool-bars 'grow-only) has no effect (pgtk) Richard Hansen
2022-07-17  5:46 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-17  5:57 ` Eli Zaretskii [this message]
2022-07-17 10:02   ` Eli Zaretskii
2022-07-17 23:37   ` Richard Hansen
2022-07-18  0:55     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-18  3:37       ` Richard Hansen
2022-07-18  4:35         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-18  5:43           ` Richard Hansen
2022-07-18  6:24             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-17  9:20 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83cze4qo1a.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=56607@debbugs.gnu.org \
    --cc=rhansen@rhansen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).