From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57079: 29.0.50; Performance of seq-uniq is not very good Date: Tue, 09 Aug 2022 20:50:11 +0300 Message-ID: <83czd9tigc.fsf@gnu.org> References: <83tu6ltlcq.fsf@gnu.org> <87y1vxwe0y.fsf@gnus.org> <83k07htjxf.fsf@gnu.org> <87o7wtwcu9.fsf@gnus.org> <83fsi5tj31.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38572"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57079@debbugs.gnu.org To: larsi@gnus.org, stefan@marxist.se Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 09 20:08:58 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLTf0-0009qv-1K for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 20:08:58 +0200 Original-Received: from localhost ([::1]:37684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLTey-0004ge-JG for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 14:08:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLTNf-0000so-6K for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 13:51:12 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55089) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLTNe-0000qe-Oa for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 13:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLTNe-0005xv-K5 for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 13:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Aug 2022 17:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57079 X-GNU-PR-Package: emacs Original-Received: via spool by 57079-submit@debbugs.gnu.org id=B57079.166006743222877 (code B ref 57079); Tue, 09 Aug 2022 17:51:02 +0000 Original-Received: (at 57079) by debbugs.gnu.org; 9 Aug 2022 17:50:32 +0000 Original-Received: from localhost ([127.0.0.1]:44838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLTNA-0005wv-7D for submit@debbugs.gnu.org; Tue, 09 Aug 2022 13:50:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLTN8-0005wi-Du for 57079@debbugs.gnu.org; Tue, 09 Aug 2022 13:50:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44340) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLTN1-0000nb-Cm; Tue, 09 Aug 2022 13:50:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=f6gVeHyZICzo/Rjk0Y1uTFVOJq6Ll8AAAls8Q5xVdG8=; b=SOuUqgwTEoye iIO410XGMXGZOXrUBwmdlwyIT0b7judG5QuBkbuw4r8QfRF8UVZoI+C4VQqQVPDUCJlAhR3oSDGCj WM4+z9GH0tve470cgmcm/JTRWA+5fPSfS1tUlBR9od7SvkxWOEJj+BJXRTEp7fKSus4hKClOinnWx FxdL7W/YZpZPEasz/hY8QKTPMJt7DVmzOxmhaNnyIsh7EntWUIOVzjYZucXxiNhkNG0m895iROEVK p4Ryz9mPcVxF7yTsbUXxtqqinBwfjMDK6sCojxQij+JzWTrNDNdsR+9Tg0M1hWVar093698UUib+f 7ocato9ee1kNgT6ZxUs0hg==; Original-Received: from [87.69.77.57] (port=2078 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLTN0-0000hx-Rg; Tue, 09 Aug 2022 13:50:23 -0400 In-Reply-To: <83fsi5tj31.fsf@gnu.org> (message from Eli Zaretskii on Tue, 09 Aug 2022 20:36:34 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239184 Archived-At: > Cc: 57079@debbugs.gnu.org, stefan@marxist.se > Date: Tue, 09 Aug 2022 20:36:34 +0300 > From: Eli Zaretskii > > But the above means that using seq-uniq with TESTFN nil is going to be > unnecessarily slow from the get-go. People shouldn't use seq-uniq if > they don't need a non-default TESTFN, because much faster > implementations exist. > > IOW, since this bug is about speed, not anything else, I think making > seq-uniq faster when TESTFN is nil isn't the right solution, the right > solution is to point out that seq-uniq's purpose in this case is not > to be a Speedy Gonzales. In particular, it means that this: commit 171b9314bf2b2ed1719f2451b527960e0a363a40 Author: Stefan Kangas AuthorDate: Tue Aug 9 14:29:12 2022 +0200 Commit: Stefan Kangas CommitDate: Tue Aug 9 17:58:15 2022 +0200 Replace utility functions with seq-uniq * lisp/gnus/gnus-util.el (gnus-delete-duplicates): * lisp/ibuf-ext.el (ibuffer-remove-duplicates): Redefine as obsolete function alias for 'seq-uniq'. Update callers. is incorrect: those callers should have been replaced with a faster implementation than seq-uniq could ever become.