unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 57691@debbugs.gnu.org
Subject: bug#57691: 29.0.50; image-tests failures
Date: Fri, 09 Sep 2022 15:56:30 +0300	[thread overview]
Message-ID: <83czc4d7up.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmnd2r2s64sD8PcZd1c_gMX-ZbT7pVt9KTFih-CdgQ-akQ@mail.gmail.com> (message from Stefan Kangas on Fri, 9 Sep 2022 08:44:01 -0400)

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Fri, 9 Sep 2022 08:44:01 -0400
> Cc: 57691@debbugs.gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > If w32-use-native-image-API is nil, my Emacs uses libgif v5.1.0.  By
> > default, libgif is not used at all; instead, Emacs uses MS-Windows
> > native APIs in the system library gdiplus.dll to display GIF images.
> 
> Ah, I forgot about the native image stuff.
> 
> It seems to me that the test currently assumes that we do NOT use a
> native image API.
> 
> I don't know if we (1) need to adjust the delay on MS-Windows along the
> lines of what we do in image.c [see commit 3de2462da7], or (2) should
> change the test to set w32-use-native-image-API to nil, or (3) if we
> should just skip the test on MS-Windows.

What does that test check? why does it want to see the delay?

The native APIs support animated GIFs better than with libgif, so
artificially making changes of the delay for the single benefit of
running this test is not the best idea, IMO.





  reply	other threads:[~2022-09-09 12:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-09  6:26 bug#57691: 29.0.50; image-tests failures Eli Zaretskii
2022-09-09  9:03 ` Stefan Kangas
2022-09-09 11:51   ` Eli Zaretskii
2022-09-09 12:44     ` Stefan Kangas
2022-09-09 12:56       ` Eli Zaretskii [this message]
2022-09-09 22:37         ` Stefan Kangas
2022-09-10  6:07           ` Eli Zaretskii
2022-09-12 13:23             ` Stefan Kangas
2022-09-12 16:00               ` Eli Zaretskii
2022-09-13  9:40                 ` Stefan Kangas
2022-09-13 12:05                   ` Eli Zaretskii
2022-09-09 12:44     ` Stefan Kangas
2022-09-09 12:57       ` Eli Zaretskii
2022-09-09 22:37         ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83czc4d7up.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=57691@debbugs.gnu.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).