unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: <miha@kamnitnik.top>
Cc: 58176@debbugs.gnu.org
Subject: bug#58176: 29.0.50; mouse-set-point region flicker with highlight-nonselected-windows=t and same buffer in two windows
Date: Sat, 01 Oct 2022 08:38:01 +0300	[thread overview]
Message-ID: <83czbccddy.fsf@gnu.org> (raw)
In-Reply-To: <87h70otvgs.fsf@miha-pc>

> From: <miha@kamnitnik.top>
> Cc: 58176@debbugs.gnu.org
> Date: Fri, 30 Sep 2022 23:15:31 +0200
> 
> >> Well, maybe we could try a bit harder to reduce the flicker for ordinary
> >> non-dragging mouse-1 clicks. One idea could be to prevent down-mouse-1
> >> from activating mark until the region becomes non-zero length, so
> >> something like this patch.
> >
> > Thanks, but this is exactly the opposite of the behavior we want.  We
> > currently make a significant effort to show regions of zero length.
> 
> (I'm assuming that by "show regions of zero length", you mean that the
> "Copy text" toolbar icon is enabled.)

No, we actually attempt to display zero-length regions in the text.

> I hope I'm not arguing semantics too much, but my patch doesn't actually
> hide an (active) region of zero length, it prevents one from being
> activated.

Which is against the behavior we want, I think.

> It only prevents it in the specific case of a non-dragging mouse-1
> click, which makes quite a lot sense to me. The current behaviour of a
> non-dragging mouse-1 click is that the zero-length region is only active
> for the duration of the mouse button being held down. Once the button is
> released, the zero-length region is deactivated, which makes it not very
> useful, as far as I can see.

It is useful in the much more frequent use case where the user then
drags the mouse.

> If you want to create a zero-length region that stays active after
> releasing mouse-1, you have to drag the mouse a little first to make the
> region length non-zero and then drag the mouse back to the starting
> position to make the region length zero again. This use case is still
> supported by my patch.
> 
> (Perhaps I missed some use-cases of a zero-length region active during a
> non-dragging mouse-1 button hold. If you know any, please let me know
> about them.)
> 
> This, together with the fact that it reduces the "flicker" from the
> original message, makes me insist on the patch.

I still insist that what you propose is the opposite of the behavior
we want.





  reply	other threads:[~2022-10-01  5:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29 17:38 bug#58176: 29.0.50; mouse-set-point region flicker with highlight-nonselected-windows=t and same buffer in two windows miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-29 18:54 ` Eli Zaretskii
2022-09-29 21:09   ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-30  5:45     ` Eli Zaretskii
2022-09-30 21:15       ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-01  5:38         ` Eli Zaretskii [this message]
2022-10-01 10:00           ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-01  9:58             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83czbccddy.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=58176@debbugs.gnu.org \
    --cc=miha@kamnitnik.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).