From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59628: 29.0.50; treesit-beginning/end-of-defun problems in C/C++ Date: Thu, 01 Dec 2022 10:08:43 +0200 Message-ID: <83cz93im0k.fsf@gnu.org> References: <0A2994D9-54DC-48EC-8705-46893A962442@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25439"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59628-done@debbugs.gnu.org, mardani29@yahoo.es To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 01 09:10:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0eeJ-0006SK-7T for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Dec 2022 09:10:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0eeB-0002SV-19; Thu, 01 Dec 2022 03:10:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0ee6-0002R3-SX for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 03:10:15 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0edu-000869-Ma for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 03:10:11 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0edu-0006AU-4K for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 03:10:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Dec 2022 08:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59628 X-GNU-PR-Package: emacs Mail-Followup-To: 59628@debbugs.gnu.org, eliz@gnu.org, eliz@gnu.org Original-Received: via spool by 59628-done@debbugs.gnu.org id=D59628.166988217723696 (code D ref 59628); Thu, 01 Dec 2022 08:10:01 +0000 Original-Received: (at 59628-done) by debbugs.gnu.org; 1 Dec 2022 08:09:37 +0000 Original-Received: from localhost ([127.0.0.1]:38148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0edV-0006A8-5H for submit@debbugs.gnu.org; Thu, 01 Dec 2022 03:09:37 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0edS-0006A2-Tf for 59628-done@debbugs.gnu.org; Thu, 01 Dec 2022 03:09:35 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0edN-00082B-7Z; Thu, 01 Dec 2022 03:09:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=2UF9TR978vNAvyqtS0WWra67Qt/Lj+OIz89r4Bre0YY=; b=McwVdUPxFxAKTm9SBLMk K6ULLcy03i4xEbQy7zEq/8jwcz4IrlbtxtIZ6MofHsLre9mRrazs4/NwY8OuKDZY61Sd8Mg5x4TrU KT+wcBKEV4sbSqOPZjD9tdSY3K3AX82pUZXCbGBp0Xg9yF57N7VPkEZZL90ziTNcW5lhQfGV8ajS2 TUnDwH71wSnl3vnkY3VvdzMpR8egN0oCcW+2s43zRwWf190FYwzukibo8q9T6dUhxnYQIyf0GZIgG OFB4UELjoBxfVQHgT4wDIU42F2NtxSwiIIdvNvNru5gNzJ8BGAvwHl96qKjA0X5OAMU6/1bomVKEV wPyG8lG7bRo0og==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0ed6-0004Rc-D6; Thu, 01 Dec 2022 03:09:26 -0500 In-Reply-To: <0A2994D9-54DC-48EC-8705-46893A962442@gmail.com> (message from Yuan Fu on Wed, 30 Nov 2022 15:07:45 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249607 Archived-At: > From: Yuan Fu > Date: Wed, 30 Nov 2022 15:07:45 -0800 > Cc: eliz@gnu.org, > 59628@debbugs.gnu.org > > > Daniel Martín writes: > > > Yuan Fu writes: > > > >> > >> Different languages have different grammars that give different names to > >> function definitions and class definitions. So it is necessary to have a > >> regexp variable. Finding such a regexp isn’t too hard, so I don’t think > >> we need a default value. If we do have a default, it would be often wrong, > >> given differences between language grammars. > > > > I see that each major mode sets the value of that buffer-local variable. > > c-ts-mode sets it to "\\(?:definition\\|specifier\\)" but, is that > > correct? In C code, treesit-explore-mode shows function definition > > nodes as "function_definition", so I think the regexp is matching more > > nodes than expected, causing C-M-a C-M-e to move to weird places in the > > buffer. > > Right, I’ve fixed the value in 599369bf3a3. Thanks, this seems to work now as expected. So I'm closing the bug.