From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61535: 29.0.60; choose-completion erases in-region buffer Date: Sun, 19 Feb 2023 20:35:21 +0200 Message-ID: <83cz65wljq.fsf@gnu.org> References: <86y1oylrap.fsf@mail.linkov.net> <83ilg2afip.fsf@gnu.org> <86edqpebxy.fsf@mail.linkov.net> <83bklt2wz6.fsf@gnu.org> <86bklsem93.fsf@mail.linkov.net> <83mt5c1ydo.fsf@gnu.org> <86h6vilsqe.fsf@mail.linkov.net> <83r0umydnm.fsf@gnu.org> <86sff1muj4.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27288"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61535@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 19 19:36:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pToXv-0006t5-Hm for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Feb 2023 19:36:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pToXc-0007eR-31; Sun, 19 Feb 2023 13:36:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pToXa-0007eG-Fn for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 13:36:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pToXa-0006km-78 for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 13:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pToXZ-0007t5-Tf for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 13:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Feb 2023 18:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61535 X-GNU-PR-Package: emacs Original-Received: via spool by 61535-submit@debbugs.gnu.org id=B61535.167683173730286 (code B ref 61535); Sun, 19 Feb 2023 18:36:01 +0000 Original-Received: (at 61535) by debbugs.gnu.org; 19 Feb 2023 18:35:37 +0000 Original-Received: from localhost ([127.0.0.1]:49639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pToXA-0007sQ-VQ for submit@debbugs.gnu.org; Sun, 19 Feb 2023 13:35:37 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pToX9-0007sD-GY for 61535@debbugs.gnu.org; Sun, 19 Feb 2023 13:35:35 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pToWz-0006em-BO; Sun, 19 Feb 2023 13:35:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kJvunqNfuj9BubN7vDRoV8E9gCKYQs56iucI4QFLvM4=; b=UrmAJ0EHc+Wn IEa0oN338CbvQU+zJL02YB3qxyCkxxdusnHRSeUT83DHtqY0+SEZ92DX1zh0WfNQw4CN52RFK/FIw wJQayzvqvamRbe0a+nfltYJzvgYJW23qL2AvYl0K0hGEQgwRcsbOgVJ6Tyb9kHNT10pOPnEs4+fPH +IH5hIxuE51jfp+qJKoNAfYURxApKlW9guxhwmocPmZWWKXr0GAQB+U+cqzk8pJU+LLteAbksB91E NFYzMkIY/wDwIVXiuQnUx1StD2ICaWSbn6CFOpdGy/MVl15riG7Y77Qm/hXG7BasTzp2D9ApvgU3B xk0FDT9GNcvzQPjzBy5o1Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pToWo-0001Ki-ML; Sun, 19 Feb 2023 13:35:24 -0500 In-Reply-To: <86sff1muj4.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 19 Feb 2023 19:31:27 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256096 Archived-At: > From: Juri Linkov > Cc: 61535@debbugs.gnu.org > Date: Sun, 19 Feb 2023 19:31:27 +0200 > > > But by default, completion-in-region-mode is t and > > completion-use-base-affixes is nil. So this code is never executed in > > the recipe you posted, right? > > M-RET is bound to minibuffer-choose-completion in completion-in-region-mode-map. > minibuffer-choose-completion let-binds completion-use-base-affixes to t > before calling choose-completion. Therefore completion-use-base-affixes > should be ignored in choose-completion for completion-in-region-mode. OK, thanks for the explanations. I wonder if some of the above should be in comments to the code, though. Please install the patch on emacs-29.