From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 61535@debbugs.gnu.org
Subject: bug#61535: 29.0.60; choose-completion erases in-region buffer
Date: Sun, 19 Feb 2023 20:35:21 +0200 [thread overview]
Message-ID: <83cz65wljq.fsf@gnu.org> (raw)
In-Reply-To: <86sff1muj4.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 19 Feb 2023 19:31:27 +0200)
> From: Juri Linkov <juri@linkov.net>
> Cc: 61535@debbugs.gnu.org
> Date: Sun, 19 Feb 2023 19:31:27 +0200
>
> > But by default, completion-in-region-mode is t and
> > completion-use-base-affixes is nil. So this code is never executed in
> > the recipe you posted, right?
>
> M-RET is bound to minibuffer-choose-completion in completion-in-region-mode-map.
> minibuffer-choose-completion let-binds completion-use-base-affixes to t
> before calling choose-completion. Therefore completion-use-base-affixes
> should be ignored in choose-completion for completion-in-region-mode.
OK, thanks for the explanations. I wonder if some of the above should
be in comments to the code, though.
Please install the patch on emacs-29.
next prev parent reply other threads:[~2023-02-19 18:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 18:32 bug#61535: 29.0.60; choose-completion erases in-region buffer Juri Linkov
2023-02-15 19:35 ` Eli Zaretskii
2023-02-16 17:51 ` Juri Linkov
2023-02-16 20:09 ` Eli Zaretskii
2023-02-17 7:50 ` Juri Linkov
2023-02-17 8:37 ` Eli Zaretskii
2023-02-18 18:43 ` Juri Linkov
2023-02-18 19:30 ` Eli Zaretskii
2023-02-19 17:31 ` Juri Linkov
2023-02-19 18:35 ` Eli Zaretskii [this message]
2023-02-19 19:32 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83cz65wljq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61535@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).