From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired Date: Tue, 21 Feb 2023 15:03:44 +0200 Message-ID: <83cz63tbkf.fsf@gnu.org> References: <87sff1quwk.fsf@ledu-giraud.fr> <83sff0v6wz.fsf@gnu.org> <87ttzgtq6p.fsf@ledu-giraud.fr> <83edqkv48n.fsf@gnu.org> <87k00ctofi.fsf@ledu-giraud.fr> <83a618v1jj.fsf@gnu.org> <87bklothkw.fsf@ledu-giraud.fr> <83ttzfteg1.fsf@gnu.org> <87y1orrz7f.fsf@ledu-giraud.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26806"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61639@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 21 14:04:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pUSJl-0006oz-7A for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Feb 2023 14:04:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUSJR-0007Ot-8v; Tue, 21 Feb 2023 08:04:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUSJO-0007LB-Ml for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2023 08:04:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUSJO-0002kB-2M for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2023 08:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pUSJN-0003Vh-UG for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2023 08:04:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Feb 2023 13:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61639-submit@debbugs.gnu.org id=B61639.167698462213465 (code B ref 61639); Tue, 21 Feb 2023 13:04:01 +0000 Original-Received: (at 61639) by debbugs.gnu.org; 21 Feb 2023 13:03:42 +0000 Original-Received: from localhost ([127.0.0.1]:54902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUSJ4-0003V7-IT for submit@debbugs.gnu.org; Tue, 21 Feb 2023 08:03:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUSJ0-0003Ur-Ug for 61639@debbugs.gnu.org; Tue, 21 Feb 2023 08:03:40 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUSIv-0002fO-4I; Tue, 21 Feb 2023 08:03:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=mxg50jABpWIQ8hRDzJ7Xg5cdWbPPTX6Q6+ONBCCsW2k=; b=CdoQEk3FUKnIJDpifpVJ AQpb+MkM4qyg44VC/AkCWtDaAidkyTPedcMn55ishjEKIT+uZ92vKOnzQWGXz/aU4/6nHzdt93XCr Z5OpEavxDdJtdQYMb6iwQiuy9JRV0YGXAkEGToOJht7uNN5DpaSrFfQfGgn9rvuakNLizVYOSKk9h eildQ0N++fmofpzzYc0AA8N5psVv/F4YZcgSHgSK9Ujq3Er3KhNi7nUe+6qs5+eT28+P2/91GhFSy ocVXohPGkRYmFxAbFUYGipd+bzv1G4VbF5pht4wNS3ZqE3Jcebcz/fzqV+4zKoQYPWvbsYj/H+GsC 3YvJNSM+Dz822g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUSIu-00059G-G5; Tue, 21 Feb 2023 08:03:32 -0500 In-Reply-To: <87y1orrz7f.fsf@ledu-giraud.fr> (message from Manuel Giraud on Tue, 21 Feb 2023 13:16:04 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256263 Archived-At: > From: Manuel Giraud > Cc: 61639@debbugs.gnu.org > Date: Tue, 21 Feb 2023 13:16:04 +0100 > > Eli Zaretskii writes: > > [...] > > > Thanks. This LGTM, but what is 'plusp'? > > 'plusp' is a classic Common Lisp predicate (that also seems to be > defined in Emacs). It is equivalent to (> x 0)… maybe you prefer that. > Should I fix my patch? Where is it defined? It isn't defined in "emacs -Q", and not after loading image-dired. (Tested in Emacs 29.)