unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Gregory Heytings <gregory@heytings.org>
Cc: luangruo@yahoo.com, 61704@debbugs.gnu.org
Subject: bug#61704: 29.0.60; Crash in get_narrowed_begv
Date: Wed, 22 Feb 2023 14:59:51 +0200	[thread overview]
Message-ID: <83cz61svnc.fsf@gnu.org> (raw)
In-Reply-To: <e737b605e9c064e56128@heytings.org> (message from Gregory Heytings on Wed, 22 Feb 2023 12:48:02 +0000)

> Cc: 61704@debbugs.gnu.org
> Date: Wed, 22 Feb 2023 12:48:02 +0000
> From: Gregory Heytings <gregory@heytings.org>
> 
> 
> > The cause is an arithmetic trap in get_narrowed_begv:
> >
> > return max ((pos / len - 1) * len, BEGV);
> >
> > where len is 0.  The window was previously being resized, and has a 
> > pixel width of 24.
> >
> 
> How can len possibly be 0 at that point?  It is (in short) 
> window_body_width (w, WINDOW_BODY_IN_CANONICAL_CHARS) * window_body_height 
> (w, WINDOW_BODY_IN_CANONICAL_CHARS).  We could add a condition in 
> get_narrowed_len to return 1 when the result is 0, but it could be a bug 
> somewhere else (can a window body have a zero width and/or height?), in 
> which case it would be better to fix the bug there.

I agree that we should understand how this happened (and asked a
similar question), but I installed a defensive protection anyway.  It
cannot do any harm.





  reply	other threads:[~2023-02-22 12:59 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set>
2023-02-22 12:20 ` bug#61704: 29.0.60; Crash in get_narrowed_begv Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-22 12:48   ` Gregory Heytings
2023-02-22 12:59     ` Eli Zaretskii [this message]
2023-02-22 13:16       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-22 13:40         ` Gregory Heytings
2023-02-22 13:47           ` Eli Zaretskii
2023-02-22 14:12           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-22 14:18             ` Gregory Heytings
2023-02-22 13:17       ` Gregory Heytings
2023-02-22 13:44         ` Eli Zaretskii
2023-02-23  9:33           ` martin rudalics
2023-02-23  9:37             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-23  9:46               ` martin rudalics
2023-02-23 13:07                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-23 15:28                   ` martin rudalics
2023-02-23 10:51               ` Eli Zaretskii
2023-02-23 13:08                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-23 10:54               ` Gregory Heytings
2023-02-23 13:11                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-23 13:23                   ` Gregory Heytings
2023-02-23 15:28                 ` martin rudalics
2023-02-23 15:54                   ` Gregory Heytings
2023-02-23 17:41                     ` martin rudalics
2023-02-23 10:44             ` Eli Zaretskii
2023-02-23 15:27               ` martin rudalics
2023-02-22 12:57   ` Eli Zaretskii
2023-02-22 13:23     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83cz61svnc.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=61704@debbugs.gnu.org \
    --cc=gregory@heytings.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).