unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Mohsin Kaleem <mohkale@kisara.moe>
Cc: 62265@debbugs.gnu.org
Subject: bug#62265: Underline does not work in Terminal Emacs
Date: Sat, 18 Mar 2023 20:01:42 +0200	[thread overview]
Message-ID: <83cz56aqgp.fsf@gnu.org> (raw)
In-Reply-To: <87wn3ex8ik.fsf@kisara.moe> (message from Mohsin Kaleem on Sat, 18 Mar 2023 17:40:51 +0000)

> From: Mohsin Kaleem <mohkale@kisara.moe>
> Date: Sat, 18 Mar 2023 17:40:51 +0000
> 
> Underline support for tty frames was added to Emacs back in the Emacs
> 28.0.90 release. It hasn't worked for me since. Today I tried
> investigating why. I tracked it down ncurses and discovered the tgetstr
> function to retrieve the escape sequence for underline support doesn't
> fetch the value configured in the terminfo database for my Terminal
> (st). I can reproduce this function failing to fetch the entry in a
> minimal sample program (code attached).
> [...]
> --- a/src/term.c
> +++ b/src/term.c
> @@ -4163,7 +4163,11 @@ use the Bourne shell command 'TERM=...; export TERM' (C-shell:\n\
>    tty->TS_enter_alt_charset_mode = tgetstr ("as", address);
>    tty->TS_exit_alt_charset_mode = tgetstr ("ae", address);
>    tty->TS_exit_attribute_mode = tgetstr ("me", address);
> +#ifdef TERMINFO
> +  tty->TS_enter_strike_through_mode = tigetstr ("smxx");
> +#else
>    tty->TS_enter_strike_through_mode = tgetstr ("smxx", address);
> +#end

There's something I don't understand here: you are talking about
underline support, but the proposed patch affects the support for
strike-through, not underline.  What am I missing here?





  parent reply	other threads:[~2023-03-18 18:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-18 17:40 bug#62265: Underline does not work in Terminal Emacs Mohsin Kaleem
2023-03-18 17:51 ` Mohsin Kaleem
2023-03-18 17:55 ` Eli Zaretskii
2023-03-18 18:50   ` Jim Porter
2023-03-19 10:07     ` Mohsin Kaleem
2023-03-19 11:37       ` Eli Zaretskii
2023-03-19 11:51         ` Mohsin Kaleem
2023-03-19 12:24           ` Eli Zaretskii
2023-04-16  6:22             ` Eli Zaretskii
2023-03-18 18:01 ` Eli Zaretskii [this message]
2023-03-18 18:07   ` Mohsin Kaleem

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83cz56aqgp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=62265@debbugs.gnu.org \
    --cc=mohkale@kisara.moe \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).