From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65325: "make check" hangs on Cygwin Date: Sat, 19 Aug 2023 09:15:32 +0300 Message-ID: <83cyzj36d7.fsf@gnu.org> References: <12489762.80ggfzRhTf@nimes> <83pm3n8ao6.fsf@gnu.org> <99d99342-55b0-e3ba-fdec-cf4547d48226@cornell.edu> <60b81c61-b46f-b091-80e1-3fad5a2f044d@cornell.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21456"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65325@debbugs.gnu.org, bruno@clisp.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 19 08:16:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXFG6-0005Na-H5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Aug 2023 08:16:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXFFj-000836-8N; Sat, 19 Aug 2023 02:16:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXFFh-00082G-N7 for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 02:16:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXFFh-0007D3-EN for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 02:16:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXFFh-0001Hf-Pz for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 02:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Aug 2023 06:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65325 X-GNU-PR-Package: emacs Original-Received: via spool by 65325-submit@debbugs.gnu.org id=B65325.16924257314896 (code B ref 65325); Sat, 19 Aug 2023 06:16:01 +0000 Original-Received: (at 65325) by debbugs.gnu.org; 19 Aug 2023 06:15:31 +0000 Original-Received: from localhost ([127.0.0.1]:49251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXFFD-0001Gt-B0 for submit@debbugs.gnu.org; Sat, 19 Aug 2023 02:15:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXFFB-0001Gd-FM for 65325@debbugs.gnu.org; Sat, 19 Aug 2023 02:15:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXFF3-0006nC-28; Sat, 19 Aug 2023 02:15:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=E+aenmsWVnanIUpOr+T+r/qmxMf/0b8o5GKyPG6qhpQ=; b=ax34L+7sTFND047O9uz/ jynYwhF4S+eSPag1FHzqRJLo4ODIjU/UlIG91wLDA86a0au88tISTo68DS44fWRtAoUu+2FUkvyU1 8tKj6hudq94L39VugljvkmEXF96WtN9sycw0MLFixd0M9uNINlef+vzXQWnKlypUcpKZTYifcjv5I IgrTBqfcaWqK+wk/v0BxYUrK9isFtUSF17L16PxqqaRbOvVDukk8NiMaF5Prkf/wbWC4QdrGnSppB BF7ZENg6c8o3JpeNbbQDuxCVsy9yQ+eJPFtsY4N5Vn/M5OH9QEs57lvKaYT5BvrVWmyMzNouMseik lCdOQ1eTiJ11gQ==; In-Reply-To: <60b81c61-b46f-b091-80e1-3fad5a2f044d@cornell.edu> (message from Ken Brown on Fri, 18 Aug 2023 18:02:46 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267816 Archived-At: > Date: Fri, 18 Aug 2023 18:02:46 -0400 > From: Ken Brown > Cc: 65325@debbugs.gnu.org > > > I can reproduce the hang.  But I don't get the hang in the default build > > on my system (no configure options).  I'll have to play with the > > configure options and try to figure out what's going on. > > OK, the hang in server-tests.el [and a similar hang in > keyboard-tests.el] occurs when getchar is called at keyboard.c:3978. > This call only occurs if dbus, file notification, and threads are all > disabled, i.e., if the configure options without-dbus, > without-file-notification, and without-threads are all specified or > implied. I don't understand the keyboard code well enough to know (a) > why we reach that call to getchar in the context of the hanging tests > and (b) why getchar is only called in the absence of dbus, file > notification, and threads. Because we have no other way to read input in such a build. The code we have there obviously cannot handle anything but character input from stdin, so it is a small wonder that it hangs in an ERT test. I think this is a red herring: we should skip these tests if none of those 3 features is available. (We could also rewrite the tests to support such a build, but I have very little sympathy for people who build Emacs --without-all and still want to run all the test suite successfully, and thus I don't think this would be a worthwhile investment of our energy and resources.) > I can work around the problem by always avoiding that getchar call on > Cygwin (i.e., by adding "&& !defined CYGWIN" at line 3972). With that > change, all tests pass on Cygwin with Bruno's configure options. But I > don't want to make that change without understanding what's going on. > Can anyone help? I don't think it's a Cygwin-only failure. But if it is, it is also OK to skip these tests only on Cygwin, in addition to testing the absence of those 3 features. Thanks.