From: Eli Zaretskii <eliz@gnu.org>
To: Ken Brown <kbrown@cornell.edu>
Cc: 65325@debbugs.gnu.org, bruno@clisp.org
Subject: bug#65325: "make check" hangs on Cygwin
Date: Sat, 19 Aug 2023 09:15:32 +0300 [thread overview]
Message-ID: <83cyzj36d7.fsf@gnu.org> (raw)
In-Reply-To: <60b81c61-b46f-b091-80e1-3fad5a2f044d@cornell.edu> (message from Ken Brown on Fri, 18 Aug 2023 18:02:46 -0400)
> Date: Fri, 18 Aug 2023 18:02:46 -0400
> From: Ken Brown <kbrown@cornell.edu>
> Cc: 65325@debbugs.gnu.org
>
> > I can reproduce the hang. But I don't get the hang in the default build
> > on my system (no configure options). I'll have to play with the
> > configure options and try to figure out what's going on.
>
> OK, the hang in server-tests.el [and a similar hang in
> keyboard-tests.el] occurs when getchar is called at keyboard.c:3978.
> This call only occurs if dbus, file notification, and threads are all
> disabled, i.e., if the configure options without-dbus,
> without-file-notification, and without-threads are all specified or
> implied. I don't understand the keyboard code well enough to know (a)
> why we reach that call to getchar in the context of the hanging tests
> and (b) why getchar is only called in the absence of dbus, file
> notification, and threads.
Because we have no other way to read input in such a build. The code
we have there obviously cannot handle anything but character input
from stdin, so it is a small wonder that it hangs in an ERT test.
I think this is a red herring: we should skip these tests if none of
those 3 features is available. (We could also rewrite the tests to
support such a build, but I have very little sympathy for people who
build Emacs --without-all and still want to run all the test suite
successfully, and thus I don't think this would be a worthwhile
investment of our energy and resources.)
> I can work around the problem by always avoiding that getchar call on
> Cygwin (i.e., by adding "&& !defined CYGWIN" at line 3972). With that
> change, all tests pass on Cygwin with Bruno's configure options. But I
> don't want to make that change without understanding what's going on.
> Can anyone help?
I don't think it's a Cygwin-only failure. But if it is, it is also OK
to skip these tests only on Cygwin, in addition to testing the absence
of those 3 features.
Thanks.
next prev parent reply other threads:[~2023-08-19 6:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 22:08 bug#65325: "make check" hangs on Cygwin Bruno Haible
2023-08-16 11:54 ` Eli Zaretskii
2023-08-16 13:58 ` Bruno Haible
2023-08-16 15:23 ` Ken Brown
2023-08-16 17:49 ` Ken Brown
2023-08-18 22:02 ` Ken Brown
2023-08-19 6:15 ` Eli Zaretskii [this message]
2023-08-19 16:43 ` Ken Brown
2023-08-19 17:02 ` Bruno Haible
2023-08-19 18:25 ` Ken Brown
2023-08-19 19:54 ` Eli Zaretskii
2023-08-19 20:58 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83cyzj36d7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65325@debbugs.gnu.org \
--cc=bruno@clisp.org \
--cc=kbrown@cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).