From: Eli Zaretskii <eliz@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: luangruo@yahoo.com, stefankangas@gmail.com, 64440@debbugs.gnu.org
Subject: bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items
Date: Mon, 11 Sep 2023 16:41:12 +0300 [thread overview]
Message-ID: <83cyyorfnr.fsf@gnu.org> (raw)
In-Reply-To: <87cyyo28m0.fsf@ledu-giraud.fr> (message from Manuel Giraud on Mon, 11 Sep 2023 14:32:39 +0200)
> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: luangruo@yahoo.com, stefankangas@gmail.com, 64440@debbugs.gnu.org
> Date: Mon, 11 Sep 2023 14:32:39 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> + *x_end = *x_start;
> >> + for (i = *h_start; i < *h_end; ++i)
> >> + *x_end += row->glyphs[TEXT_AREA][i].pixel_width;
> >>
> >> Here, I convert those limits from chars to pixels.
> >
> > What does this glyph_row look like? Does it include several strings
> > one after the other or something?
> >
> > In general, we always test the index of a glyph in a glyph row against
> > glyphs[TEXT_AREA].used, and I'm worried that these tests are absent
> > from the code above. Which is why I'm asking for more details about
> > the arrangement of the menu text in these glyph rows.
>
> Hi,
>
> Here's what a "p *row" returns right after the "row = MATRIX_ROW
> (w->current_matrix, *vpos);" line:
>
> (gdb) p *row
> $9 = {
> glyphs = {0xef4a19dd000, 0xef4a19dd000, 0xef4a19e0510, 0xef4a19e0510},
> used = {0, 120, 0, 0},
> hash = 221095522,
> x = 0,
> y = 0,
> pixel_width = 840,
> ascent = 11,
> height = 13,
> phys_ascent = 10,
> phys_height = 12,
> visible_height = 13,
> extra_line_spacing = 0,
> start = {
> pos = {
> charpos = 0,
> bytepos = 0
> },
> overlay_string_index = 0,
> string_pos = {
> charpos = 0,
> bytepos = 0
> },
> dpvec_index = 0
> },
> end = {
> pos = {
> charpos = 0,
> bytepos = 0
> },
> overlay_string_index = 0,
> string_pos = {
> charpos = 0,
> bytepos = 0
> },
> dpvec_index = 0
> },
> minpos = {
> charpos = 0,
> bytepos = 0
> },
> maxpos = {
> charpos = 0,
> bytepos = 0
> },
> overlay_arrow_bitmap = 0,
> left_user_fringe_bitmap = 0,
> right_user_fringe_bitmap = 0,
> left_fringe_bitmap = 0,
> right_fringe_bitmap = 0,
> left_user_fringe_face_id = 0,
> right_user_fringe_face_id = 0,
> left_fringe_face_id = 0,
> right_fringe_face_id = 0,
> left_fringe_offset = 0,
> right_fringe_offset = 0,
> fringe_bitmap_periodic_p = false,
> redraw_fringe_bitmaps_p = false,
> enabled_p = true,
> truncated_on_left_p = false,
> truncated_on_right_p = false,
> continued_p = false,
> displays_text_p = false,
> ends_at_zv_p = false,
> fill_line_p = false,
> indicate_empty_line_p = false,
> contains_overlapping_glyphs_p = false,
> full_width_p = true,
> mode_line_p = false,
> tab_line_p = false,
> overlapped_p = false,
> ends_in_middle_of_char_p = false,
> starts_in_middle_of_char_p = false,
> overlapping_p = false,
> mouse_face_p = false,
> ends_in_newline_from_string_p = false,
> exact_window_width_line_p = false,
> cursor_in_fringe_p = false,
> ends_in_ellipsis_p = false,
> indicate_bob_p = false,
> indicate_top_line_p = false,
> indicate_eob_p = false,
> indicate_bottom_line_p = false,
> reversed_p = false,
> stipple_p = false,
> continuation_lines_width = 0,
> clip = 0x0
> }
>
> Is that what you are looking for?
This gives some of the answers, but the command 'pgrow' (defined on
src/.gdbinit) would have done that better, and would also show the
glyphs themselves. Can you show what 'pgrow' produces in this case?
next prev parent reply other threads:[~2023-09-11 13:41 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 15:59 bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-04 16:14 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-01 18:55 ` Stefan Kangas
2023-09-02 0:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-02 6:41 ` Eli Zaretskii
2023-09-02 13:09 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-05 9:53 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-10 7:31 ` Eli Zaretskii
2023-09-10 7:33 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-11 12:32 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-11 13:41 ` Eli Zaretskii [this message]
2023-09-11 14:59 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-11 15:58 ` Eli Zaretskii
2023-09-11 18:56 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-11 19:12 ` Eli Zaretskii
2023-09-11 20:51 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-12 11:13 ` Eli Zaretskii
2023-09-12 11:26 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-12 12:48 ` Eli Zaretskii
2023-09-12 13:06 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-12 13:15 ` Eli Zaretskii
2023-09-12 13:19 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-12 13:34 ` Eli Zaretskii
2023-09-12 13:42 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-12 13:56 ` Stefan Kangas
2023-09-12 14:06 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-12 14:27 ` Stefan Kangas
2023-09-13 16:48 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-06 12:49 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-06 13:14 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-06 15:39 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-06 15:59 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-21 10:19 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-21 10:28 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-21 11:02 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-21 11:10 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-21 12:02 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-21 12:27 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-21 12:44 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-21 12:48 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-21 13:03 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-21 13:24 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-21 13:56 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-27 8:11 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-27 8:18 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-27 10:35 ` Eli Zaretskii
2023-10-28 5:26 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-29 9:02 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-29 10:18 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-21 11:10 ` Stefan Kangas
2023-10-21 12:06 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-21 10:31 ` Stefan Kangas
2023-09-11 12:51 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-02 13:05 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83cyyorfnr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64440@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
--cc=manuel@ledu-giraud.fr \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).