From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>, Paul Eggert <eggert@cs.ucla.edu>
Cc: 66186@debbugs.gnu.org, jschmidt4gnu@vodafonemail.de
Subject: bug#66186: "make lisp/eshell/esh-proc-tests" fails intermittently since 7e50861ca7ed3f620fe62ac6572f6e88b3600ece
Date: Mon, 25 Sep 2023 09:47:42 +0300 [thread overview]
Message-ID: <83cyy63g1d.fsf@gnu.org> (raw)
In-Reply-To: <fef0e892-aa22-0d16-2f36-bf9b10048bd0@gmail.com> (message from Jim Porter on Sun, 24 Sep 2023 22:47:58 -0700)
> Date: Sun, 24 Sep 2023 22:47:58 -0700
> From: Jim Porter <jporterbugs@gmail.com>
> Cc: jschmidt4gnu@vodafonemail.de, 66186@debbugs.gnu.org
>
> >> Perhaps Eshell should check that the process is still alive before
> >> calling process-send-string?
> >
> > Ok, how about this? Jens, could you try this patch out to see if it
> > fixes things for you?
>
> I forgot to add: Is there potential for a race condition here? I think
> I'd written it the other way because there's a chance that the process
> exits in between checking 'process-live-p' and calling
> 'process-send-string'.
Yes, and therefore I think you should also keep the old code that
wrapped the call in condition-case.
> I guess we could check liveness both before *and*
> after 'process-send-string'. That would probably still leave a small
> chance of the regression tests crashing though, which isn't great.
Perhaps process-send-string should install a temporary SIGPIPE
handler, at least optionally? Paul, WDYT?
> I could probably also write the test to avoid this race condition
> entirely, since it's not actually trying to trigger a SIGPIPE (though in
> general, Eshell should do the right thing in response to SIGPIPE). That
> would make the regression tests happy.
That's always a good thing, thanks.
next prev parent reply other threads:[~2023-09-25 6:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 21:35 bug#66186: "make lisp/eshell/esh-proc-tests" fails intermittently since 7e50861ca7ed3f620fe62ac6572f6e88b3600ece Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-24 23:02 ` Jim Porter
2023-09-25 4:52 ` Eli Zaretskii
2023-09-25 5:34 ` Jim Porter
2023-09-25 5:47 ` Jim Porter
2023-09-25 6:47 ` Eli Zaretskii [this message]
2023-09-25 7:18 ` Paul Eggert
2023-09-25 7:43 ` Eli Zaretskii
2023-09-25 19:12 ` Jim Porter
2023-09-28 20:33 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-01 20:13 ` Jim Porter
2023-09-25 9:01 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83cyy63g1d.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=66186@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=jporterbugs@gmail.com \
--cc=jschmidt4gnu@vodafonemail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).