unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Chris Hanson <cph@chris-hanson.org>
Cc: 66288@debbugs.gnu.org
Subject: bug#66288: 29.1; Performance regression using pipe for subprocess
Date: Tue, 03 Oct 2023 10:32:36 +0300	[thread overview]
Message-ID: <83cyxw6u0b.fsf@gnu.org> (raw)
In-Reply-To: <fab8e074-ac2c-41ff-b88c-50db6bc0e680@chris-hanson.org> (message from Chris Hanson on Mon, 2 Oct 2023 14:22:06 -0400)

> Date: Mon, 2 Oct 2023 14:22:06 -0400
> Cc: 66288@debbugs.gnu.org
> From: Chris Hanson <cph@chris-hanson.org>
> 
> > Finally, if you describe in plain English how xscheme.el reads
> > subprocess output at the stage where you see the slowdown, it might
> > give further ideas.  I'm not familiar with xscheme.el, and figuring
> > out which code gets executed when one runs "run-scheme" is not
> > trivial, so a detailed enough description might help.  Specifically,
> > how does xscheme.el decide how much of the subprocess's output to read
> > and display?
> 
> The process filter has one complexity: it looks for encoded commands 
> from the subprocess, which are of the form "ESC <char>" or "ESC <char> 
> <string> ESC", depending on the <char>.  There is a small state machine 
> to do that, which searches the output string for ESC using 
> `string-search'. In this case there are no commands embedded, so that 
> should not be relevant.
> 
> The ordinary text is inserted into the process buffer using standard 
> filter-output code, except it looks for BEL and translates that to 
> (beep) if found.  In this case there are no occurrences of BEL in the 
> output, so that's not relevant.  So, basically the output string is 
> passed to `insert', making sure that process mark and point are updated 
> appropriately.

Thanks.  It would be good to see the Lisp profiler results for your
recipes, in both versions of Emacs, to understand whether any of these
Lisp parts have anything to do with the issue.  (You say that these
aspects of the processing are not relevant, but maybe they have some
overhead even when the special characters and commands do not appear
in the output?)





      parent reply	other threads:[~2023-10-03  7:32 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-01  0:57 bug#66288: 29.1; Performance regression using pipe for subprocess Chris Hanson
2023-10-01  8:39 ` Eli Zaretskii
2023-10-01 18:02   ` Chris Hanson
2023-10-02  5:02     ` Eli Zaretskii
2023-10-02  5:07       ` Eli Zaretskii
2023-10-02 17:14         ` Chris Hanson
2023-10-02  5:36       ` Eli Zaretskii
2023-10-02 18:22         ` Chris Hanson
2023-10-02 19:12           ` Gerd Möllmann
2023-10-02 19:27             ` Dmitry Gutov
2023-10-02 19:40               ` Gerd Möllmann
2023-10-02 20:15                 ` Dmitry Gutov
2023-10-02 23:23               ` Chris Hanson
2023-10-03  5:06                 ` Gerd Möllmann
2023-10-03  6:22                 ` Eli Zaretskii
2023-10-03  6:48                   ` Eli Zaretskii
2023-10-03 17:24                   ` Eli Zaretskii
2023-10-03 19:12                     ` Chris Hanson
2023-10-03 20:22                       ` Dmitry Gutov
2023-10-03 17:42                   ` Dmitry Gutov
2023-10-03 17:57                     ` Eli Zaretskii
2023-10-03 20:58                       ` Gregory Heytings
2023-10-03 21:26                         ` Dmitry Gutov
2023-10-04  0:33                           ` Chris Hanson
2023-10-04  6:52                             ` Eli Zaretskii
2023-10-04  9:10                               ` Gregory Heytings
2023-10-04 10:09                               ` Dmitry Gutov
2023-10-04 17:55                               ` Chris Hanson
2023-10-04 22:49                               ` Paul Eggert
2023-10-04 22:54                                 ` Dmitry Gutov
2023-10-05  5:50                                   ` Eli Zaretskii
2023-10-05 10:48                                     ` Dmitry Gutov
2023-10-06  5:34                                       ` Eli Zaretskii
2023-10-05  5:49                                 ` Eli Zaretskii
2023-10-04  4:11                         ` Gerd Möllmann
2023-10-04  6:55                         ` Eli Zaretskii
2023-10-03  7:32           ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83cyxw6u0b.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=66288@debbugs.gnu.org \
    --cc=cph@chris-hanson.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).