From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66317: Project mode-line Date: Fri, 06 Oct 2023 07:50:02 +0300 Message-ID: <83cyxs2w3p.fsf@gnu.org> References: <86jzs4ntxb.fsf@mail.linkov.net> <86sf6r4omc.fsf@mail.linkov.net> <86jzs34mg6.fsf@mail.linkov.net> <83zg0z6062.fsf@gnu.org> <86il7mc3xr.fsf@mail.linkov.net> <456e170e-2934-9f8b-e34a-3076901f8de1@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6170"; mail-complaints-to="usenet@ciao.gmane.io" Cc: me@eshelyaron.com, 66317@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 06 06:51:03 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qocnn-0001Ky-Fw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Oct 2023 06:51:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qocnW-0001Cx-5X; Fri, 06 Oct 2023 00:50:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qocnU-0001CZ-AR for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 00:50:44 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qocnU-0006bL-0b for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 00:50:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qocnm-0000l1-J5 for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 00:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Oct 2023 04:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66317 X-GNU-PR-Package: emacs Original-Received: via spool by 66317-submit@debbugs.gnu.org id=B66317.16965678242865 (code B ref 66317); Fri, 06 Oct 2023 04:51:02 +0000 Original-Received: (at 66317) by debbugs.gnu.org; 6 Oct 2023 04:50:24 +0000 Original-Received: from localhost ([127.0.0.1]:48999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qocn9-0000k8-GD for submit@debbugs.gnu.org; Fri, 06 Oct 2023 00:50:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qocn7-0000jp-0Z for 66317@debbugs.gnu.org; Fri, 06 Oct 2023 00:50:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qocmh-0006M6-6y; Fri, 06 Oct 2023 00:49:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nrrefbM2VBZYbeQSez8xI8jq/nBlONipW6kD/7VcwrQ=; b=V+M9bf+/viIV Ie3bwvFNnLkeALxVYNodugvnMaGB8mWJO2NfARGoaaag2Ebj0ahUQ8mLjbH0BO5rCOobR2XF6/aYI VHnlD/Cs39+h6EJ9Dv3JTAFXso9gEXe99JfzUQdGIuicZ3nnwxtvtAbSsad2hNVpdgVzCIdlAE6kr YmPe2gksBrRwchquqwT349uiqlNI1ug/Z6644LAPtHuNjzkqUWPU0LkRrdvGPCxqUz8ORPhE7WtQj c1uiROImKW7n6VNQaPs08acDYecGJ2r6a9w4WRGz2hwxHtNZBPQ3bZv0WHH6xWiKt7Evyg0KB5lno 1DFYB+QdX8ZDCr2RZoaIxg==; In-Reply-To: <456e170e-2934-9f8b-e34a-3076901f8de1@gutov.dev> (message from Dmitry Gutov on Thu, 5 Oct 2023 23:23:17 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271926 Archived-At: > Date: Thu, 5 Oct 2023 23:23:17 +0300 > Cc: 66317@debbugs.gnu.org, me@eshelyaron.com > From: Dmitry Gutov > > On 04/10/2023 09:18, Juri Linkov wrote: > > diff --git a/lisp/bindings.el b/lisp/bindings.el > > index 207adb3a2a4..70e4087e131 100644 > > --- a/lisp/bindings.el > > +++ b/lisp/bindings.el > > @@ -682,6 +682,7 @@ mode-line-end-spaces > > 'mode-line-buffer-identification > > " " > > 'mode-line-position > > + '(project-mode-line project-mode-line-format) > > '(vc-mode vc-mode) > > " " > > 'mode-line-modes > > Speaking of this change from the first patch, do we want to have > project-mode-line automatically supported in Emacs <= 29, when they > install the new version from ELPA? Can we safely do that? > > Simply altering mode-line-format, as in the original patch, might mess > up the custom mode-line the user had set up (or installed). How to only > change the default mode-line is less obvious, but perhaps checking that > the current value is equal to (get 'mode-line-format 'standard-value) > would mean altering is okay. > > Or otherwise we should say something in the docstring of > project-mode-line: that it's only directly supported in Emacs 30, and in > older versions the user need to add the corresponding entry to the > mode-line-format by hand. I think supporting it in Emacs 30 is fine. It's a very minor feature, after all, so let's not invest too much effort in it.