From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did) Date: Sat, 21 Oct 2023 10:35:09 +0300 Message-ID: <83cyx8sa1e.fsf@gnu.org> References: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com> <1034a4cb-217a-4e60-a474-bf07948e3dd1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33613"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefankangas@gmail.com, 66635@debbugs.gnu.org To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 21 09:35:53 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qu6WX-0008Qn-IB for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Oct 2023 09:35:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qu6WG-0001uI-Hq; Sat, 21 Oct 2023 03:35:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qu6WE-0001u2-W8 for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 03:35:35 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qu6WE-0005Bb-NZ for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 03:35:34 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qu6Wg-0006lG-Ac for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 03:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2023 07:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66635-submit@debbugs.gnu.org id=B66635.169787375725980 (code B ref 66635); Sat, 21 Oct 2023 07:36:02 +0000 Original-Received: (at 66635) by debbugs.gnu.org; 21 Oct 2023 07:35:57 +0000 Original-Received: from localhost ([127.0.0.1]:42115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu6WX-0006kt-PS for submit@debbugs.gnu.org; Sat, 21 Oct 2023 03:35:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu6WS-0006gh-O8 for 66635@debbugs.gnu.org; Sat, 21 Oct 2023 03:35:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qu6Vu-00052s-2Y; Sat, 21 Oct 2023 03:35:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ruOGFWHye9Rm4xEcyGiGP6Z8sNIBnme4PVXEV7CY7cE=; b=Wk7uN5mwvNI6TnVGgrWF lRsb6dCehUISrPghz8YaEEdNy3Es9XEY8MlTE/3R0B+d2e3ayobnTYOjXWJav4Amd8Ev2C15k5fAD 6jEyrqjzCLChp3FNYToMq2SEtPmgeWwoMDXXe2AFVQNjmtsPSxPgaiGYsqdFmPB6vaTl0FgTj8Uat Ezd2suEvrxyE2Bs1pu0+1Pd9r+NDfcD28xyppCf4viYgwr7OMz/gRE24FWfxfw9tkIns2XDkvHyi9 2KqAyZ9EgJdiqegmEIj2696IeaC3HbmMC/Kl69KTcW19WiGEpo18JUdfvLU3UoLuAfHjAGsuO2oha ECv7xtUZ5eSc7w==; In-Reply-To: <1034a4cb-217a-4e60-a474-bf07948e3dd1@gmail.com> (message from Mauro Aranda on Fri, 20 Oct 2023 21:21:34 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272835 Archived-At: > Date: Fri, 20 Oct 2023 21:21:34 -0300 > From: Mauro Aranda > > On 20/10/23 18:08, Stefan Kangas wrote: > > Mauro Aranda writes: > > > >> I attach a patch to address the more important issues for now.  That is, > >> at least have a working State button and rudimentary state checking. > >> > >> Setting and Saving icon specifications through the State button should > >> work now, by adding the custom-icon-action function. > > > > > > Thanks for working on this. > > > > Do you propose this patch for emacs-29?  It seems quite intrusive on the > > face of it, but OTOH `customize-icon' is new in Emacs 29, so there is no > > risk of regressions if this stuff never worked in the first place.  Or > > is that wrong? > > I'm not aware of all things you and Eli have to take into account when > deciding whether a patch is good for emacs-29.  I know the non-intrusive > or localized, and the safe part.  This patch is certainly neither, but > it's the minimum (OK, maybe not the bare minimum) to make customizing > icons work for an user.  I think that's a good reason for the patch to > go into emacs-29, but I won't be insisting on it, specially if it is a > burden, considering 29.1.90 pretest is out. icons.el is a new package in Emacs 29, so maybe such changes in it to fix a serious problem are okay even at this stage. How well is the fix tested? Did you test it with several icons introduced in Emacs 29 in various modes? If not, would you please test those and see the changes work well enough there to be appropriate for a bug-fix release? Thanks.