From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67005: 30.0.50; improve nadivce/comp/trampoline handling Date: Thu, 23 Nov 2023 08:19:04 +0200 Message-ID: <83cyw1gffr.fsf@gnu.org> References: <874jhv9921.fsf@sappc2.fritz.box> <875y24zrt1.fsf@sappc2.fritz.box> <87ttpmwuxi.fsf@sappc2.fritz.box> <877cmct4a1.fsf@sappc2.fritz.box> <87bkbmiwpf.fsf@sappc2.fritz.box> <87leap8n1z.fsf@sappc2.fritz.box> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33448"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acorallo@gnu.org, monnier@iro.umontreal.ca, 67005@debbugs.gnu.org To: Jens Schmidt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 23 07:20:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r634Y-0008Rx-OG for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Nov 2023 07:20:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r634J-0001nx-RG; Thu, 23 Nov 2023 01:20:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r634H-0001nl-IY for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2023 01:20:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r634A-0008Mk-QP for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2023 01:20:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r634E-0002P5-Fv for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2023 01:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Nov 2023 06:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67005 X-GNU-PR-Package: emacs Original-Received: via spool by 67005-submit@debbugs.gnu.org id=B67005.17007203669175 (code B ref 67005); Thu, 23 Nov 2023 06:20:02 +0000 Original-Received: (at 67005) by debbugs.gnu.org; 23 Nov 2023 06:19:26 +0000 Original-Received: from localhost ([127.0.0.1]:60403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r633d-0002Nv-Vt for submit@debbugs.gnu.org; Thu, 23 Nov 2023 01:19:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r633b-0002Ng-Cc for 67005@debbugs.gnu.org; Thu, 23 Nov 2023 01:19:24 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r633R-0008HX-Un; Thu, 23 Nov 2023 01:19:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iHA5hkDbATdF8GBq8nBlRGFyXYOxwyjF7NbEzhp2Eo4=; b=oYOIzrbObsoB Y8led2jjwFMC83xntaYzPij0WWK/Rc/Xd+loWgPU7P1kTfYtTTEEqEv28tzZiqh1MYknoPRKdpKYB QYGeXnX7Z+xYLNkd8t9H3KvWLLc/fPEhkZaWX5CEVV/OGvaa2/aMgtAhi+qv8as+3hytj3z5CouyL uqlLH5n78YOqpqMMppc3+HY+/Eni8Eo6I7SBuLl+OrK83Fd3tsooOF+Z/ZbpNH23bF5PrQtI9e2cP +2ztpVKJzn8OaqZrt0KxbrfcqSdB+mYfhcd2Cl5xjagZ1BSIQzfaUVrDn+olrrLDyr3WcFwJK1YDi Tw0IM5NbWlQ7wuaq8H2tcw==; In-Reply-To: <87leap8n1z.fsf@sappc2.fritz.box> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274791 Archived-At: > Cc: andrea corallo , 67005@debbugs.gnu.org > Date: Wed, 22 Nov 2023 23:01:44 +0100 > From: Jens Schmidt via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > diff --git a/lisp/emacs-lisp/nadvice.el b/lisp/emacs-lisp/nadvice.el > index 42027c01491..c43d1b86752 100644 > --- a/lisp/emacs-lisp/nadvice.el > +++ b/lisp/emacs-lisp/nadvice.el > @@ -507,10 +507,15 @@ advice-add > is defined as a macro, alias, command, ... > HOW can be one of: > <<>>" > + ;; Actively disallow function advices during bootstrap for the > + ;; following reasons: > + ;; - Advices in Emacs' core are generally considered bad style. > + ;; - `Snarf-documentation' looses docstrings of advised dumped > + ;; functions (bug#66032#20). > ;; TODO: > ;; - record the advice location, to display in describe-function. > - ;; - change all defadvice in lisp/**/*.el. > - ;; - obsolete advice.el. Does this patch resolve the 2 TODO items you are now deleting? Or were they already resolved by previous changes, and we just failed to keep the comments up-to-date?