From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.bugs
Subject: bug#67835: 30.0.50; Error with undocumented disabled commands
Date: Sat, 16 Dec 2023 15:11:24 +0200
Message-ID: <83cyv6mgw3.fsf@gnu.org>
References: <87bkarn3ra.wl@id.domain>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-7
Content-Transfer-Encoding: 8bit
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="1582"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: 67835@debbugs.gnu.org
To: kakkokakko@gmail.com, Stefan Kangas <stefankangas@gmail.com>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 16 14:12:22 2023
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>)
	id 1rEUSs-0000Cf-AH
	for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Dec 2023 14:12:22 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <bug-gnu-emacs-bounces@gnu.org>)
	id 1rEUSd-0000lh-Rj; Sat, 16 Dec 2023 08:12:08 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1rEUSY-0000lY-Tw
 for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 08:12:04 -0500
Original-Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1rEUSY-0000so-20
 for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 08:12:02 -0500
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rEUSY-0001to-99
 for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 08:12:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Eli Zaretskii <eliz@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Sat, 16 Dec 2023 13:12:02 +0000
Resent-Message-ID: <handler.67835.B67835.17027323127260@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 67835
X-GNU-PR-Package: emacs
Original-Received: via spool by 67835-submit@debbugs.gnu.org id=B67835.17027323127260
 (code B ref 67835); Sat, 16 Dec 2023 13:12:02 +0000
Original-Received: (at 67835) by debbugs.gnu.org; 16 Dec 2023 13:11:52 +0000
Original-Received: from localhost ([127.0.0.1]:54207 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1rEUSO-0001t1-0h
 for submit@debbugs.gnu.org; Sat, 16 Dec 2023 08:11:52 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40192)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@gnu.org>) id 1rEUSL-0001sj-9B
 for 67835@debbugs.gnu.org; Sat, 16 Dec 2023 08:11:50 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1rEUSE-0008VT-Ck; Sat, 16 Dec 2023 08:11:42 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=i+SBya0XNbrq0E5ySiZgT4bj8ZGyGo69t9gW1hLDoiE=; b=Ys9Ob9N69VjJCAt71m1D
 g3ZVSwlZHPfz3q5sLBzJRCo1TpJ/a6UjZPqS2MmxW4NHm3jd4OEfbfolIo49cDKpaVW15ca5+W+Xr
 Fmrl2b62WVvOk/Uw0S2zyYehrBqSGmFR/qbqH6bTjCh1SlppTYq9f4AQlRU1/vyBeLMEMRjf/cObV
 yBi/8MRqsYppOxEtYYtX9jEfqRlyNw3Wx0R7cjxBlrEctZ7zV9hXzp66lK/FauQcowCwLPjN2jsyp
 sFQkTBeaLaYLGZpvisQERDQl4m9qPvlYSr0d3diCLEBdUY9+/thWJ8sgvuE8s+srTLt1y0glKy9ve
 Dh+txut1px/trw==;
In-Reply-To: <87bkarn3ra.wl@id.domain> (kakkokakko@gmail.com)
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.bugs:276333
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/276333>

> Date: Fri, 15 Dec 2023 19:45:13 +0900
> From: kakkokakko@gmail.com
> 
> 1. emacs -Q --eval "(progn (defun foo () (interactive)) (put 'foo 'disabled t))"
> 2. M-x foo RET
> 
> Then, I encountered the error message "Wrong type argument:
> char-or-string-p, nil". This behavior is different from that in
> previous versions, like 27.1, where I received the following message.
> 
> | You have invoked the disabled command foo.
> | It is disabled because new users often find it confusing.
> | Here’s the first part of its description:
> | 
> |    << not documented >>
> | ...
> 
> I also expect similar behavior in 30.0.50.
> 
> In 30.0.50, it appears that disabled-command-function in
> novice.el triggers this error by executing (insert nil) for
> undocumented commands in the following code.
> 
> | (insert (condition-case ()
> |             (documentation cmd)
> |           (error "<< not documented >>")))
> 
> Although omitting a docstring is generally considered poor practice,
> triggering an error for such commands might not be intentional
> behavior. The corresponding code in 27.1 was as follows:
> 
> | (... (or (condition-case ()
> |               (documentation cmd)
> |            (error nil))
> |          "<< not documented >>"))

Stefan, could you please look into this?  The above seems to come from
your changes in commit 6ad79059d2f843a1be617c72ae0e9d8a02c9a203.  I'd
like to fix this on the emacs-29 branch soon, if possible.

Thanks.