From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68174: 30.0.50; Project and VC disagree about what repository we're in Date: Wed, 03 Jan 2024 14:41:03 +0200 Message-ID: <83cyuizj1c.fsf@gnu.org> References: <87bka6y041.fsf@zephyr.silentflame.com> <8c47be44-ea77-48b5-bbdf-53b4e245f7a7@gutov.dev> <8734vgqfld.fsf@zephyr.silentflame.com> <2a278850-2241-4e43-b81f-1cefdfe7d930@gutov.dev> <83v88bzwx0.fsf@gnu.org> <08d721c2-905e-4818-8c87-b1de6481d0e6@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39367"; mail-complaints-to="usenet@ciao.gmane.io" Cc: juri@linkov.net, 68174@debbugs.gnu.org, spwhitton@spwhitton.name To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 03 13:42:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rL0Zh-000A0w-Rb for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Jan 2024 13:42:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rL0ZQ-0004xw-Jo; Wed, 03 Jan 2024 07:42:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rL0ZN-0004ul-Al for bug-gnu-emacs@gnu.org; Wed, 03 Jan 2024 07:42:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rL0ZL-00009t-9r for bug-gnu-emacs@gnu.org; Wed, 03 Jan 2024 07:42:00 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rL0ZO-0003QH-0B for bug-gnu-emacs@gnu.org; Wed, 03 Jan 2024 07:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Jan 2024 12:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68174 X-GNU-PR-Package: emacs Original-Received: via spool by 68174-submit@debbugs.gnu.org id=B68174.170428569513126 (code B ref 68174); Wed, 03 Jan 2024 12:42:01 +0000 Original-Received: (at 68174) by debbugs.gnu.org; 3 Jan 2024 12:41:35 +0000 Original-Received: from localhost ([127.0.0.1]:51954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rL0Yx-0003Pd-EQ for submit@debbugs.gnu.org; Wed, 03 Jan 2024 07:41:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rL0Ys-0003PM-Gs for 68174@debbugs.gnu.org; Wed, 03 Jan 2024 07:41:33 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rL0Yj-0008Qq-Ol; Wed, 03 Jan 2024 07:41:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=V+KPeyIXrJMA/lfU+XnO7qqh3WWxDp3XmNSdLrf8TI0=; b=EB3sYjBqLXmd DghE2NAfQt9caSf4FvuBAhHB6QVDdWSDS3iv0RWvNNWdQLLRWIkvlfWP6Byb0I9oiiV6ta6Avq08y j5eiDqrc5b4Q5fCME4HOweRFrQvB4vuHOJ8QioUxXwF6375+FU2wpn334yUQiIRRZiy2bDP2oBNy2 1e7NtqN/tz3HCcrxp7ZGqW1E7XzdZ6V7MnWNojG0cFBesE27pGciYxzFSONT6fMS9jjWF3UPE8OHX /+RZeya/6BBXBu4161fn64E6lJRlNrsWI2oO+xeEFP8XhXPtnYSyGNcA2oWK9mxjcgJ8wjcfN8D7L 3oYMOW2G5zb7O0qcdWjYQA==; In-Reply-To: <08d721c2-905e-4818-8c87-b1de6481d0e6@gutov.dev> (message from Dmitry Gutov on Wed, 3 Jan 2024 02:13:07 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277272 Archived-At: > Date: Wed, 3 Jan 2024 02:13:07 +0200 > Cc: spwhitton@spwhitton.name, 68174-done@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > > > If it's safe, you'd need to convince me. Because just by looking at > > it, I don't have a clear idea what else it could affect. > > It's not a trivial transformation, but it's semantically sound: > log-view-mode saves -- or one might say caches -- the backend and the > fileset in its own variables locally (referenced in the diff above). The > commands in log-view.el (of which there are several) use those vars > rather than look up vc-parent-buffer, so the values should be correct. Thanks. Let's see if there are some use cases which actually benefit from an ad-hoc decision at that place instead of using the stashed values.