From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 8664@debbugs.gnu.org
Subject: bug#8664: Being more-systematic about user-interface timestamps
Date: Sat, 14 May 2011 12:41:20 +0300 [thread overview]
Message-ID: <83boz5fwlb.fsf@gnu.org> (raw)
In-Reply-To: <4DCE4703.30703@cs.ucla.edu>
> Date: Sat, 14 May 2011 02:10:27 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: 8664@debbugs.gnu.org
>
> No change should be needed for w32's hooks, since there's no actual change
> to the data type there.
It will break if the typedef is ever changed to be incompatible.
> For documentation purposes it might be nice to run through the hooks
> and change 'unsigned long' to 'Time' where appropriate, but that's
> not essential. Normally I'm reluctant to mess with the w32 code as
> I can't easily test it.
Changing a single declaration to an obviously correct one, and an
equivalent one at that, can hardly be qualified as "messing".
Besides, people will understand if you botch their build trying to
keep it from breaking, but may not understand why you knowingly
refrain from making a change that clearly is TRT.
next prev parent reply other threads:[~2011-05-14 9:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 19:58 bug#8664: * keyboard.c (make_lispy_event): Fix problem in integer overflow Paul Eggert
2011-05-12 20:26 ` bug#8664: Being more-systematic about user-interface timestamps Paul Eggert
2011-05-13 8:53 ` Eli Zaretskii
2011-05-14 9:10 ` Paul Eggert
2011-05-14 9:41 ` Eli Zaretskii [this message]
2011-05-14 19:09 ` Paul Eggert
2011-05-14 20:47 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2011-05-16 5:07 bug#8675: lisp_string_width and strings wider than INT_MAX Paul Eggert
2011-05-16 5:30 ` Eli Zaretskii
2011-05-16 5:33 ` Paul Eggert
2011-05-16 7:57 ` Eli Zaretskii
2011-05-16 16:37 ` Paul Eggert
2011-05-16 16:48 ` Stefan Monnier
2011-05-17 9:52 ` Eli Zaretskii
2011-05-18 1:33 ` bug#8675: committed fix into trunk Paul Eggert
2011-05-18 2:26 ` Christoph Scholtes
2011-05-18 2:48 ` Paul Eggert
2011-05-18 3:19 ` Christoph Scholtes
2011-05-18 12:39 ` Andreas Schwab
2011-05-18 19:55 ` bug#8675: error: token "@" is not valid in preprocessor expressions Paul Eggert
[not found] ` <4DD42421.6090906@cs.ucla.edu>
2011-05-18 20:35 ` Andreas Schwab
[not found] ` <m262p7u4ph.fsf@igel.home>
2011-05-18 22:59 ` Paul Eggert
[not found] ` <4DD44F42.1050405@cs.ucla.edu>
2011-05-19 0:27 ` Bruno Haible
[not found] ` <201105190227.26215.bruno@clisp.org>
2011-05-19 1:47 ` Christoph Scholtes
2011-05-19 7:39 ` Paul Eggert
2011-05-18 6:54 ` bug#8664: committed fix into trunk Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83boz5fwlb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=8664@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).