From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#17210: 24.3.50; help mode [back] link to a C-h b keybind listing fails with message "Current buffer is not in Help mode" Date: Tue, 08 Apr 2014 18:26:13 +0300 Message-ID: <83bnwb7sh6.fsf@gnu.org> References: <5341E798.4060004@iankelling.org> <5342585B.9070603@gmx.at> <83ob0d6sow.fsf@gnu.org> <5343A1B4.6010005@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1396970844 27356 80.91.229.3 (8 Apr 2014 15:27:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Apr 2014 15:27:24 +0000 (UTC) Cc: ian@iankelling.org, 17210@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 08 17:27:18 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WXXvg-00024Z-Vg for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Apr 2014 17:27:17 +0200 Original-Received: from localhost ([::1]:40946 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXXvg-000673-Iz for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Apr 2014 11:27:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXXvX-0005yx-2e for bug-gnu-emacs@gnu.org; Tue, 08 Apr 2014 11:27:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXXvS-0003GV-Bi for bug-gnu-emacs@gnu.org; Tue, 08 Apr 2014 11:27:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXXvS-0003Fx-86 for bug-gnu-emacs@gnu.org; Tue, 08 Apr 2014 11:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WXXvR-0004Lv-K1 for bug-gnu-emacs@gnu.org; Tue, 08 Apr 2014 11:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Apr 2014 15:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17210 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17210-submit@debbugs.gnu.org id=B17210.139697078716667 (code B ref 17210); Tue, 08 Apr 2014 15:27:01 +0000 Original-Received: (at 17210) by debbugs.gnu.org; 8 Apr 2014 15:26:27 +0000 Original-Received: from localhost ([127.0.0.1]:41002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WXXus-0004Kk-FZ for submit@debbugs.gnu.org; Tue, 08 Apr 2014 11:26:26 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:38922) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WXXuo-0004Ka-Qf for 17210@debbugs.gnu.org; Tue, 08 Apr 2014 11:26:24 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N3P00H00XIMTX00@a-mtaout22.012.net.il> for 17210@debbugs.gnu.org; Tue, 08 Apr 2014 18:26:20 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N3P00G26XJWWCC0@a-mtaout22.012.net.il>; Tue, 08 Apr 2014 18:26:20 +0300 (IDT) In-reply-to: <5343A1B4.6010005@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87883 Archived-At: > Date: Tue, 08 Apr 2014 09:13:56 +0200 > From: martin rudalics > CC: ian@iankelling.org, 17210@debbugs.gnu.org > > note that the bug which is the subject of the current thread was > implicitly caused by reverting a behavior erroneously introduced in > Emacs 24.3 (see the threads of bug#16816 and bug#17007 for details). Only by side effect, because all that stuff had nothing to do with which buffer is current when describe-bindings-internal is called. > > Also, describe-bindings-internal is only called from this single > > place, so I see no reason to support some other help buffers. Do you? > > I think Stefan explained that meanwhile. As long as describe-bindings invokes describe-bindings-internal with the current buffer set to the buffer whose keybindings we want to describe, I don't understand how the multitude of Help buffer can be relevant to the issue at hand. My problem with help-buffer is that calling it requires intimate understanding of its internal logic, because the caller doesn't necessarily know whether help-xref-following is bound to nil or not. Without knowing that, whoever calls help-buffer can easily trip on this problem. So it sounds like help-buffer is only suitable for callers who bind help-xref-following themselves, or have tight relationships with functions that do. describe-bindings-internal doesn't, so I don't see how it can be clean for it to call that function.