From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: ian@iankelling.org, 17210@debbugs.gnu.org
Subject: bug#17210: 24.3.50; help mode [back] link to a C-h b keybind listing fails with message "Current buffer is not in Help mode"
Date: Tue, 08 Apr 2014 18:26:13 +0300 [thread overview]
Message-ID: <83bnwb7sh6.fsf@gnu.org> (raw)
In-Reply-To: <5343A1B4.6010005@gmx.at>
> Date: Tue, 08 Apr 2014 09:13:56 +0200
> From: martin rudalics <rudalics@gmx.at>
> CC: ian@iankelling.org, 17210@debbugs.gnu.org
>
> note that the bug which is the subject of the current thread was
> implicitly caused by reverting a behavior erroneously introduced in
> Emacs 24.3 (see the threads of bug#16816 and bug#17007 for details).
Only by side effect, because all that stuff had nothing to do with
which buffer is current when describe-bindings-internal is called.
> > Also, describe-bindings-internal is only called from this single
> > place, so I see no reason to support some other help buffers. Do you?
>
> I think Stefan explained that meanwhile.
As long as describe-bindings invokes describe-bindings-internal with
the current buffer set to the buffer whose keybindings we want to
describe, I don't understand how the multitude of Help buffer can be
relevant to the issue at hand.
My problem with help-buffer is that calling it requires intimate
understanding of its internal logic, because the caller doesn't
necessarily know whether help-xref-following is bound to nil or not.
Without knowing that, whoever calls help-buffer can easily trip on
this problem. So it sounds like help-buffer is only suitable for
callers who bind help-xref-following themselves, or have tight
relationships with functions that do. describe-bindings-internal
doesn't, so I don't see how it can be clean for it to call that
function.
next prev parent reply other threads:[~2014-04-08 15:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-06 23:47 bug#17210: 24.3.50; help mode [back] link to a C-h b keybind listing fails with message "Current buffer is not in Help mode" Ian Kelling
2014-04-07 7:48 ` martin rudalics
2014-04-07 15:54 ` Eli Zaretskii
2014-04-07 18:17 ` Stefan Monnier
2014-04-08 7:14 ` martin rudalics
2014-04-08 8:32 ` Juri Linkov
2014-04-08 9:18 ` martin rudalics
2014-04-08 15:27 ` Eli Zaretskii
2014-04-08 16:34 ` martin rudalics
2014-04-08 16:42 ` Eli Zaretskii
2014-04-08 17:01 ` martin rudalics
2014-04-08 17:08 ` martin rudalics
2014-04-08 17:16 ` Andreas Schwab
2014-04-08 7:13 ` martin rudalics
2014-04-08 15:26 ` Eli Zaretskii [this message]
2014-04-08 19:49 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bnwb7sh6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=17210@debbugs.gnu.org \
--cc=ian@iankelling.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).