From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20072: Incorrect popup showing Date: Tue, 10 Mar 2015 19:03:41 +0200 Message-ID: <83bnk06az6.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1426007126 15893 80.91.229.3 (10 Mar 2015 17:05:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Mar 2015 17:05:26 +0000 (UTC) Cc: 20072@debbugs.gnu.org To: Nikolay Puzanov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 10 18:05:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YVNak-0005VI-R1 for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Mar 2015 18:05:14 +0100 Original-Received: from localhost ([::1]:50442 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVNak-00062F-3B for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Mar 2015 13:05:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVNac-0005w1-Rp for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2015 13:05:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVNaZ-00022b-5R for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2015 13:05:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVNaZ-00022Q-2G for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2015 13:05:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YVNaY-0004lf-MM for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2015 13:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Mar 2015 17:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20072-submit@debbugs.gnu.org id=B20072.142600704118239 (code B ref 20072); Tue, 10 Mar 2015 17:05:02 +0000 Original-Received: (at 20072) by debbugs.gnu.org; 10 Mar 2015 17:04:01 +0000 Original-Received: from localhost ([127.0.0.1]:41888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YVNZY-0004jy-QD for submit@debbugs.gnu.org; Tue, 10 Mar 2015 13:04:01 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:65407) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YVNZW-0004jh-C3 for 20072@debbugs.gnu.org; Tue, 10 Mar 2015 13:03:59 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NL0001009XCCP00@a-mtaout22.012.net.il> for 20072@debbugs.gnu.org; Tue, 10 Mar 2015 19:03:51 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NL00015EA2E7770@a-mtaout22.012.net.il>; Tue, 10 Mar 2015 19:03:51 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100350 Archived-At: > From: Nikolay Puzanov > Date: Tue, 10 Mar 2015 10:48:38 +0000 > > I found bug on display a popup window from auto-complete-mode. I attach two > screenshot and init.el. Bug appear when global-linum-mode is on. Damn that linum-mode! > Commit e589765 bring this bug. I changed the line that seemed most appropriate. > I not understand how it work, but this patch fix it: > > --- a/src/xdisp.c > +++ b/src/xdisp.c > @@ -3434,6 +3434,7 @@ handle_stop (struct it *it) > it->dpvec = NULL; > it->current.dpvec_index = -1; > handle_overlay_change_p = !it->ignore_overlay_strings_at_pos_p; > + it->ignore_overlay_strings_at_pos_p = false; > it->ellipsis_p = 0; > > /* Use face of preceding text for ellipsis (if invisible) */ Thanks, but I don't think this is the right fix. It is fundamentally wrong to unconditionally reset this flag at that spot, because there's no way of knowing there that we have processed all the overlay strings. > Note, this patch do not break fix by e589765 > (http://lists.gnu.org/archive/html/bug-gnu-emacs/2015-02/msg00075.html). The problem fixed by e589765 is much more fundamental than just what bug 19307 reported. When I worked on the fix, I tested a lot more situations than originally reported, and some of them will be broken by your suggested change. So we need to look for another solution. > Screenshots also uploaded to the external server: > http://www.embddr.com/emacs-popup-good.png > http://www.embddr.com/emacs-popup-bad.png Thanks, I will look into this when I have time. > Init.el: > (require 'package) > (add-to-list 'package-archives '("melpa" . > "http://melpa.milkbox.net/packages/")) > (package-initialize) > > (require 'auto-complete-config) > (auto-complete-mode t) > (ac-config-default) > > (global-linum-mode t) Is it enough to do just this instead: (require 'auto-complete-config) (auto-complete-mode 1) (ac-config-default) (global-linum-mode 1) IOW, can I skip the steps that set up package.el, and instead download auto-complete manually?