From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 20707@debbugs.gnu.org
Subject: bug#20707: [PROPOSED PATCH] Use curved quoting in C-generated errors
Date: Mon, 01 Jun 2015 17:34:17 +0300 [thread overview]
Message-ID: <83bngzts46.fsf@gnu.org> (raw)
In-Reply-To: <1433144361-9424-1-git-send-email-eggert@cs.ucla.edu>
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Mon, 1 Jun 2015 00:39:21 -0700
> Cc: Paul Eggert <eggert@cs.ucla.edu>
>
> Quote with curved single quotes, ‘like this’, in diagnostics
> generated from C code. This mostly uses C11-style UTF-8 strings,
> e.g., u8"quote ‘like this’", with a backward compatibility macro
> u8 for pre-C11 compilers.
Thanks.
I see a couple of potential issues with these changes:
. They use UTF-8 encoded characters, and so will require a suitable
'coding:' cookie in the affected files, or some equivalent setting
(perhaps in .dir-locals.el?), otherwise they might not be decoded
correctly in non-UTF-8 locales. Doing so might remove at least
part of the need for using the u8 qualifier, I think.
. I think these strings will have to be decoded before they are
passed to 'error', as we never pass any unibyte strings to Lisp
interfaces without decoding them first. (We never used before any
non-ASCII characters in messages created by C sources, so this
issue never arose until now.) Doing so would also remove the need
for using the u8 qualifier, I think.
. 'error' calls 'verror', which calls 'make_string' to actually
produce the message string. However, 'make_string' is not
reliable enough wrt whether it produces unibyte or multibyte
strings, so I suggest to make sure we produce a multibyte string
from these error messages.
next prev parent reply other threads:[~2015-06-01 14:34 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 7:39 bug#20707: [PROPOSED PATCH] Use curved quoting in C-generated errors Paul Eggert
[not found] ` <mailman.4052.1433144480.904.bug-gnu-emacs@gnu.org>
2015-06-01 10:49 ` Alan Mackenzie
2015-06-01 16:01 ` Paul Eggert
2015-06-01 17:17 ` Alan Mackenzie
2015-06-01 18:50 ` Paul Eggert
2015-06-02 11:56 ` Alan Mackenzie
2015-06-02 13:25 ` Drew Adams
2015-06-02 15:39 ` Paul Eggert
2015-06-02 15:51 ` Dmitry Gutov
2015-06-02 20:05 ` Paul Eggert
2015-06-02 17:07 ` Alan Mackenzie
2015-06-02 20:44 ` Alan Mackenzie
2015-06-04 15:43 ` Paul Eggert
2015-06-06 15:54 ` Alan Mackenzie
2015-06-06 18:11 ` Paul Eggert
2015-06-06 20:50 ` Alan Mackenzie
2015-06-07 0:09 ` Paul Eggert
2015-06-08 17:18 ` Alan Mackenzie
2015-06-09 6:53 ` Paul Eggert
2015-06-09 13:34 ` Alan Mackenzie
2015-06-09 20:49 ` Paul Eggert
2015-06-09 22:46 ` Alan Mackenzie
2015-06-09 23:42 ` Paul Eggert
2015-06-10 13:39 ` Alan Mackenzie
2015-06-10 16:20 ` Paul Eggert
2015-06-10 17:39 ` Dmitry Gutov
2015-06-10 19:42 ` Paul Eggert
2015-06-10 19:17 ` Alan Mackenzie
2015-06-10 19:44 ` Paul Eggert
2015-06-11 19:06 ` Alan Mackenzie
2015-06-12 2:41 ` Paul Eggert
2015-06-12 11:25 ` Alan Mackenzie
2015-06-12 23:46 ` Paul Eggert
2015-06-13 11:54 ` Alan Mackenzie
2015-06-13 17:54 ` Paul Eggert
2015-06-07 13:17 ` Wolfgang Jenkner
2015-06-09 16:58 ` Alan Mackenzie
2015-06-02 23:26 ` Paul Eggert
2015-06-01 14:34 ` Eli Zaretskii [this message]
2015-06-01 16:48 ` Glenn Morris
2015-06-01 17:55 ` Paul Eggert
2015-06-01 18:29 ` Eli Zaretskii
2015-06-01 21:13 ` Stefan Monnier
2015-06-09 19:44 ` Wolfgang Jenkner
2015-06-11 13:06 ` bug#20707: " Andy Moreton
2020-08-12 13:02 ` bug#20707: [PROPOSED PATCH] " Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bngzts46.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=20707@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).