From: Eli Zaretskii <eliz@gnu.org>
To: Vasilij Schneidermann <v.schneidermann@gmail.com>
Cc: 22114@debbugs.gnu.org
Subject: bug#22114: 24.5; [PATCH] Allow profiler.el to display reports after stopping
Date: Tue, 08 Dec 2015 18:22:47 +0200 [thread overview]
Message-ID: <83bna0di5k.fsf@gnu.org> (raw)
In-Reply-To: <CAPGgwWRsmiD_H98FkEPUFyWuyeWO1rD0OG3HhXN9u54CP2Ad8g@mail.gmail.com>
> Date: Tue, 8 Dec 2015 09:13:58 +0100
> From: Vasilij Schneidermann <v.schneidermann@gmail.com>
>
> I've worked with a few other profilers than profiler.el so far and one
> striking difference is that they allowed you to start a profiling run,
> stop it and then retrieve the profiling log between these two points in
> time. profiler.el on the other hand flatout refuses to display a report
> after stopping which is especially puzzling given the `profiler-stop`
> docstring: "Stop started profilers. Profiler logs will be kept." If
> the logs are kept after all, why can't I take a look at them?
>
> I've attached a patch that solves this by caching the last accessable
> profiler log. This allows both workflows to work, be it displaying a
> report while the profiler is still running or displaying it after
> stopping the profiler.
Thanks. But I don't see why we would need to keep a copy of the
profile around (and it looks weird to do that anyway, when we have a
function that reports it). When profiler-cpu-log is called, it
returns the profile before it resets it, so the data is available and
should simply be used.
I don't really understand why profiler.el insists on having the
profiler running for providing the profile. The much simpler patch
below makes it possible for me to invoke profiler-report whether a
profile is running or not. Does it work for you? If not, can you
tell what I missed?
--- lisp/profiler.el~4 2015-11-11 07:57:32.000000000 +0200
+++ lisp/profiler.el 2015-12-08 17:54:27.380084700 +0200
@@ -216,19 +216,17 @@
(defun profiler-cpu-profile ()
"Return CPU profile."
- (when (profiler-running-p 'cpu)
- (profiler-make-profile
- :type 'cpu
- :timestamp (current-time)
- :log (profiler-cpu-log))))
+ (profiler-make-profile
+ :type 'cpu
+ :timestamp (current-time)
+ :log (profiler-cpu-log)))
(defun profiler-memory-profile ()
"Return memory profile."
- (when (profiler-memory-running-p)
- (profiler-make-profile
- :type 'memory
- :timestamp (current-time)
- :log (profiler-memory-log))))
+ (profiler-make-profile
+ :type 'memory
+ :timestamp (current-time)
+ :log (profiler-memory-log)))
\f
;;; Calltrees
@@ -846,12 +844,12 @@
(defun profiler-report-cpu ()
(let ((profile (profiler-cpu-profile)))
- (when profile
+ (when (and profile (profiler-profile-log profile))
(profiler-report-profile-other-window profile))))
(defun profiler-report-memory ()
(let ((profile (profiler-memory-profile)))
- (when profile
+ (when (and profile (profiler-profile-log profile))
(profiler-report-profile-other-window profile))))
(defun profiler-report ()
next prev parent reply other threads:[~2015-12-08 16:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 8:13 bug#22114: 24.5; [PATCH] Allow profiler.el to display reports after stopping Vasilij Schneidermann
2015-12-08 16:22 ` Eli Zaretskii [this message]
2015-12-08 16:32 ` Vasilij Schneidermann
2015-12-08 17:28 ` Eli Zaretskii
2015-12-08 17:42 ` John Wiegley
2015-12-08 17:56 ` Vasilij Schneidermann
2015-12-08 18:02 ` John Wiegley
2015-12-08 18:12 ` Vasilij Schneidermann
2015-12-08 18:08 ` Eli Zaretskii
2015-12-08 18:14 ` John Wiegley
2015-12-10 9:18 ` Vasilij Schneidermann
2015-12-13 20:33 ` Vasilij Schneidermann
2015-12-13 22:18 ` Vasilij Schneidermann
2015-12-14 4:21 ` Stefan Monnier
2015-12-14 8:28 ` Vasilij Schneidermann
2015-12-14 14:43 ` Stefan Monnier
2015-12-14 18:23 ` Vasilij Schneidermann
2015-12-15 4:29 ` Stefan Monnier
2019-06-27 18:18 ` Lars Ingebrigtsen
2019-06-30 9:21 ` Vasilij Schneidermann
2019-06-30 12:34 ` Basil L. Contovounesios
2015-12-08 16:40 ` Vasilij Schneidermann
2015-12-08 17:38 ` Eli Zaretskii
2015-12-08 17:44 ` Vasilij Schneidermann
2015-12-08 18:10 ` Eli Zaretskii
2015-12-08 19:15 ` Vasilij Schneidermann
2015-12-08 19:21 ` John Wiegley
2015-12-08 20:12 ` Eli Zaretskii
2015-12-08 20:39 ` John Wiegley
2015-12-08 20:10 ` Eli Zaretskii
2019-06-25 14:46 ` Lars Ingebrigtsen
2019-06-27 14:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bna0di5k.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=22114@debbugs.gnu.org \
--cc=v.schneidermann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).