* bug#4175: 23.1; nxml-mode: Internal error in rng-validate-mode triggered
@ 2009-09-12 0:15 Chong Yidong
[not found] ` <87r5u9r3io.fsf@thialfi.karme.de>
0 siblings, 1 reply; 13+ messages in thread
From: Chong Yidong @ 2009-09-12 0:15 UTC (permalink / raw)
To: karme; +Cc: 4175
> If I try to validate a SVG with a huge path element in nxml-mode I get
> the error: Internal error in rng-validate-mode triggered at buffer
> position 616. Stack overflow in regexp matcher.
Could you provide a precise, step-by-step recipe for reproducing this
problem, starting with `emacs -Q'?
^ permalink raw reply [flat|nested] 13+ messages in thread[parent not found: <87r5u9r3io.fsf@thialfi.karme.de>]
* bug#4175: 23.1; nxml-mode: Internal error in rng-validate-mode triggered [not found] ` <87r5u9r3io.fsf@thialfi.karme.de> @ 2016-02-12 4:23 ` Andrew Hyatt 2016-02-12 7:19 ` Eli Zaretskii 0 siblings, 1 reply; 13+ messages in thread From: Andrew Hyatt @ 2016-02-12 4:23 UTC (permalink / raw) To: Jens Thiele; +Cc: 4175 Jens Thiele <karme@berlios.de> writes: > Chong Yidong <cyd@stupidchicken.com> writes: > >>> If I try to validate a SVG with a huge path element in nxml-mode I get >>> the error: Internal error in rng-validate-mode triggered at buffer >>> position 616. Stack overflow in regexp matcher. >> >> Could you provide a precise, step-by-step recipe for reproducing this >> problem, starting with `emacs -Q'? > > emacs -Q > M-: (progn > (switch-to-buffer > (find-file > (url-file-local-copy > "http://karme.de/delme/test.svg"))) > (nxml-mode) > (switch-to-buffer "*Messages*")) > > I also attached the test file. If really needed I can create a stripped > down version. I've verified this is still a problem in Emacs 25. ^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#4175: 23.1; nxml-mode: Internal error in rng-validate-mode triggered 2016-02-12 4:23 ` Andrew Hyatt @ 2016-02-12 7:19 ` Eli Zaretskii 2016-02-12 10:12 ` Stephen Berman 0 siblings, 1 reply; 13+ messages in thread From: Eli Zaretskii @ 2016-02-12 7:19 UTC (permalink / raw) To: Andrew Hyatt; +Cc: 4175, karme > From: Andrew Hyatt <ahyatt@gmail.com> > Date: Thu, 11 Feb 2016 23:23:52 -0500 > Cc: 4175@debbugs.gnu.org > > > emacs -Q > > M-: (progn > > (switch-to-buffer > > (find-file > > (url-file-local-copy > > "http://karme.de/delme/test.svg"))) > > (nxml-mode) > > (switch-to-buffer "*Messages*")) > > > > I also attached the test file. If really needed I can create a stripped > > down version. > > I've verified this is still a problem in Emacs 25. It doesn't happen for me, FWIW. Can you show the offending regexp, and what code in nxml-mode creates it? Thanks. ^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#4175: 23.1; nxml-mode: Internal error in rng-validate-mode triggered 2016-02-12 7:19 ` Eli Zaretskii @ 2016-02-12 10:12 ` Stephen Berman 2016-02-12 12:02 ` Eli Zaretskii 0 siblings, 1 reply; 13+ messages in thread From: Stephen Berman @ 2016-02-12 10:12 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Andrew Hyatt, 4175 [-- Attachment #1: Type: text/plain, Size: 859 bytes --] On Fri, 12 Feb 2016 09:19:39 +0200 Eli Zaretskii <eliz@gnu.org> wrote: >> From: Andrew Hyatt <ahyatt@gmail.com> >> Date: Thu, 11 Feb 2016 23:23:52 -0500 >> Cc: 4175@debbugs.gnu.org >> >> > emacs -Q >> > M-: (progn >> > (switch-to-buffer >> > (find-file >> > (url-file-local-copy >> > "http://karme.de/delme/test.svg"))) >> > (nxml-mode) >> > (switch-to-buffer "*Messages*")) >> > >> > I also attached the test file. If really needed I can create a stripped >> > down version. >> >> I've verified this is still a problem in Emacs 25. > > It doesn't happen for me, FWIW. > > Can you show the offending regexp, and what code in nxml-mode creates > it? I can reproduce it in a91b4b51ddf2575d821adb8b84fdf32cff83886e (GNU Emacs 25.0.90.2 (x86_64-suse-linux-gnu, GTK+ Version 3.14.15) of 2016-02-11). Here's the backtrace: [-- Attachment #2: backtrace --] [-- Type: text/plain, Size: 634 bytes --] Debugger entered--Lisp error: (error "Stack overflow in regexp matcher") looking-at("\\(\\(?:\\(xmlns\\)\\|[_[:alpha:]][-._[:alnum:]]*\\)\\(:[_[:alpha:]][-._[:alnum:]]*\\)?\\)[ \n]*=\\(?:[ \n]*\\('[^<'& \n ]*\\([& \n ][^<']*\\)?'\\|\"[^<\"& \n ]*\\([& \n ][^<\"]*\\)?\"\\)\\(?:\\([ \n]*>\\)\\|\\(?:\\([ \n]*/\\)\\(>\\)?\\)\\|\\([ \n]+\\)\\)\\)?") xmltok-scan-attributes() xmltok-scan-after-lt() xmltok-forward() rng-forward() rng-do-some-validation-1(rng-validate-while-idle-continue-p) rng-do-some-validation(rng-validate-while-idle-continue-p) rng-validate-while-idle(#<buffer url25099xa>) #[nil "\b\204\b ^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#4175: 23.1; nxml-mode: Internal error in rng-validate-mode triggered 2016-02-12 10:12 ` Stephen Berman @ 2016-02-12 12:02 ` Eli Zaretskii 2016-02-12 12:14 ` Stephen Berman 2022-07-10 2:53 ` Stefan Kangas 0 siblings, 2 replies; 13+ messages in thread From: Eli Zaretskii @ 2016-02-12 12:02 UTC (permalink / raw) To: Stephen Berman; +Cc: ahyatt, 4175 > From: Stephen Berman <stephen.berman@gmx.net> > Cc: Andrew Hyatt <ahyatt@gmail.com>, 4175@debbugs.gnu.org > Date: Fri, 12 Feb 2016 11:12:23 +0100 > > I can reproduce it in a91b4b51ddf2575d821adb8b84fdf32cff83886e (GNU > Emacs 25.0.90.2 (x86_64-suse-linux-gnu, GTK+ Version 3.14.15) of > 2016-02-11). How large is the run-time stack on that system? > Here's the backtrace: > > Debugger entered--Lisp error: (error "Stack overflow in regexp matcher") > looking-at("\\(\\(?:\\(xmlns\\)\\|[_[:alpha:]][-._[:alnum:]]*\\)\\(:[_[:alpha:]][-._[:alnum:]]*\\)?\\)[ > \n]*=\\(?:[ > \n]*\\('[^<'& > \n ]*\\([& > \n ][^<']*\\)?'\\|\"[^<\"& > \n ]*\\([& > \n ][^<\"]*\\)?\"\\)\\(?:\\([ > \n]*>\\)\\|\\(?:\\([ > \n]*/\\)\\(>\\)?\\)\\|\\([ > \n]+\\)\\)\\)?") > xmltok-scan-attributes() > xmltok-scan-after-lt() > xmltok-forward() > rng-forward() > rng-do-some-validation-1(rng-validate-while-idle-continue-p) > rng-do-some-validation(rng-validate-while-idle-continue-p) > rng-validate-while-idle(#<buffer url25099xa>) Thanks. Perhaps some regexp guru could suggest how to make this regexp less greedy. ^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#4175: 23.1; nxml-mode: Internal error in rng-validate-mode triggered 2016-02-12 12:02 ` Eli Zaretskii @ 2016-02-12 12:14 ` Stephen Berman 2016-02-12 15:15 ` Eli Zaretskii 2022-07-10 2:53 ` Stefan Kangas 1 sibling, 1 reply; 13+ messages in thread From: Stephen Berman @ 2016-02-12 12:14 UTC (permalink / raw) To: Eli Zaretskii; +Cc: ahyatt, 4175 On Fri, 12 Feb 2016 14:02:10 +0200 Eli Zaretskii <eliz@gnu.org> wrote: >> From: Stephen Berman <stephen.berman@gmx.net> >> Cc: Andrew Hyatt <ahyatt@gmail.com>, 4175@debbugs.gnu.org >> Date: Fri, 12 Feb 2016 11:12:23 +0100 >> >> I can reproduce it in a91b4b51ddf2575d821adb8b84fdf32cff83886e (GNU >> Emacs 25.0.90.2 (x86_64-suse-linux-gnu, GTK+ Version 3.14.15) of >> 2016-02-11). > > How large is the run-time stack on that system? ulimit -s says 8192, if that's what you mean. Steve Berman ^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#4175: 23.1; nxml-mode: Internal error in rng-validate-mode triggered 2016-02-12 12:14 ` Stephen Berman @ 2016-02-12 15:15 ` Eli Zaretskii 0 siblings, 0 replies; 13+ messages in thread From: Eli Zaretskii @ 2016-02-12 15:15 UTC (permalink / raw) To: Stephen Berman; +Cc: ahyatt, 4175 > From: Stephen Berman <stephen.berman@gmx.net> > Cc: ahyatt@gmail.com, 4175@debbugs.gnu.org > Date: Fri, 12 Feb 2016 13:14:41 +0100 > > > How large is the run-time stack on that system? > > ulimit -s says 8192, if that's what you mean. Same here, but it's a 32-bit build, so maybe that's the reason. ^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#4175: 23.1; nxml-mode: Internal error in rng-validate-mode triggered 2016-02-12 12:02 ` Eli Zaretskii 2016-02-12 12:14 ` Stephen Berman @ 2022-07-10 2:53 ` Stefan Kangas 2022-07-10 9:24 ` Stephen Berman 2022-07-10 11:00 ` Mattias Engdegård 1 sibling, 2 replies; 13+ messages in thread From: Stefan Kangas @ 2022-07-10 2:53 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Mattias Engdegård, ahyatt, Stephen Berman, 4175 Eli Zaretskii <eliz@gnu.org> writes: >> From: Stephen Berman <stephen.berman@gmx.net> >> Cc: Andrew Hyatt <ahyatt@gmail.com>, 4175@debbugs.gnu.org >> Date: Fri, 12 Feb 2016 11:12:23 +0100 >> >> I can reproduce it in a91b4b51ddf2575d821adb8b84fdf32cff83886e (GNU >> Emacs 25.0.90.2 (x86_64-suse-linux-gnu, GTK+ Version 3.14.15) of >> 2016-02-11). > > How large is the run-time stack on that system? > >> Here's the backtrace: >> >> Debugger entered--Lisp error: (error "Stack overflow in regexp matcher") >> looking-at("\\(\\(?:\\(xmlns\\)\\|[_[:alpha:]][-._[:alnum:]]*\\)\\(:[_[:alpha:]][-._[:alnum:]]*\\)?\\)[ >> \n]*=\\(?:[ >> \n]*\\('[^<'& >> \n ]*\\([& >> \n ][^<']*\\)?'\\|\"[^<\"& >> \n ]*\\([& >> \n ][^<\"]*\\)?\"\\)\\(?:\\([ >> \n]*>\\)\\|\\(?:\\([ >> \n]*/\\)\\(>\\)?\\)\\|\\([ >> \n]+\\)\\)\\)?") >> xmltok-scan-attributes() >> xmltok-scan-after-lt() >> xmltok-forward() >> rng-forward() >> rng-do-some-validation-1(rng-validate-while-idle-continue-p) >> rng-do-some-validation(rng-validate-while-idle-continue-p) >> rng-validate-while-idle(#<buffer url25099xa>) > > Thanks. Perhaps some regexp guru could suggest how to make this > regexp less greedy. Maybe Mattias could take a look? ^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#4175: 23.1; nxml-mode: Internal error in rng-validate-mode triggered 2022-07-10 2:53 ` Stefan Kangas @ 2022-07-10 9:24 ` Stephen Berman 2022-07-10 10:48 ` Stefan Kangas 2022-07-10 11:00 ` Mattias Engdegård 1 sibling, 1 reply; 13+ messages in thread From: Stephen Berman @ 2022-07-10 9:24 UTC (permalink / raw) To: Stefan Kangas; +Cc: Mattias Engdegård, Eli Zaretskii, 4175, ahyatt On Sat, 9 Jul 2022 19:53:42 -0700 Stefan Kangas <stefan@marxist.se> wrote: > Eli Zaretskii <eliz@gnu.org> writes: > >>> From: Stephen Berman <stephen.berman@gmx.net> >>> Cc: Andrew Hyatt <ahyatt@gmail.com>, 4175@debbugs.gnu.org >>> Date: Fri, 12 Feb 2016 11:12:23 +0100 >>> >>> I can reproduce it in a91b4b51ddf2575d821adb8b84fdf32cff83886e (GNU >>> Emacs 25.0.90.2 (x86_64-suse-linux-gnu, GTK+ Version 3.14.15) of >>> 2016-02-11). >> >> How large is the run-time stack on that system? >> >>> Here's the backtrace: >>> >>> Debugger entered--Lisp error: (error "Stack overflow in regexp matcher") >>> looking-at("\\(\\(?:\\(xmlns\\)\\|[_[:alpha:]][-._[:alnum:]]*\\)\\(:[_[:alpha:]][-._[:alnum:]]*\\)?\\)[ >>> \n]*=\\(?:[ >>> \n]*\\('[^<'& >>> \n ]*\\([& >>> \n ][^<']*\\)?'\\|\"[^<\"& >>> \n ]*\\([& >>> \n ][^<\"]*\\)?\"\\)\\(?:\\([ >>> \n]*>\\)\\|\\(?:\\([ >>> \n]*/\\)\\(>\\)?\\)\\|\\([ >>> \n]+\\)\\)\\)?") >>> xmltok-scan-attributes() >>> xmltok-scan-after-lt() >>> xmltok-forward() >>> rng-forward() >>> rng-do-some-validation-1(rng-validate-while-idle-continue-p) >>> rng-do-some-validation(rng-validate-while-idle-continue-p) >>> rng-validate-while-idle(#<buffer url25099xa>) >> >> Thanks. Perhaps some regexp guru could suggest how to make this >> regexp less greedy. > > Maybe Mattias could take a look? FWIW, I cannot reproduce the error now with -Q in Emacs 27/28/29: in all cases the mode line of the buffer containing the XML file says "nXML valid" (both when executing the recipe with the URL, which is still valid, as well as with the test.svg file provided in the bug thread.) Steve Berman ^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#4175: 23.1; nxml-mode: Internal error in rng-validate-mode triggered 2022-07-10 9:24 ` Stephen Berman @ 2022-07-10 10:48 ` Stefan Kangas 0 siblings, 0 replies; 13+ messages in thread From: Stefan Kangas @ 2022-07-10 10:48 UTC (permalink / raw) To: Stephen Berman; +Cc: Mattias Engdegård, Eli Zaretskii, 4175, ahyatt close 4175 thanks Stephen Berman <stephen.berman@gmx.net> writes: > FWIW, I cannot reproduce the error now with -Q in Emacs 27/28/29: in all > cases the mode line of the buffer containing the XML file says "nXML > valid" (both when executing the recipe with the URL, which is still > valid, as well as with the test.svg file provided in the bug thread.) OK, let's assume it is fixed. I'm therefore closing this bug report. If anyone can still reproduce, please reopen. ^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#4175: 23.1; nxml-mode: Internal error in rng-validate-mode triggered 2022-07-10 2:53 ` Stefan Kangas 2022-07-10 9:24 ` Stephen Berman @ 2022-07-10 11:00 ` Mattias Engdegård 2022-07-10 13:06 ` Stefan Kangas 1 sibling, 1 reply; 13+ messages in thread From: Mattias Engdegård @ 2022-07-10 11:00 UTC (permalink / raw) To: Stefan Kangas; +Cc: Eli Zaretskii, Stephen Berman, 4175, ahyatt The bug is still very much there: I can reproduce it by reducing emacs_re_max_failures from 40000 to 4000. It's just a matter of file size. The failing regexp (used at xmltok.el:735) is, after rx conversion, (rx (group (| (group "xmlns") (: (in "_" alpha) (* (in "._-" alnum)))) (? (group ":" (in "_" alpha) (* (in "._-" alnum))))) (* (in "\t\n\r ")) "=" (? (* (in "\t\n\r ")) (group (| (: "'" (* (not (in "\t\n\r&'<"))) (? (group (in "\t\n\r&") (* (not (in "'<"))))) "'") (: "\"" (* (not (in "\t\n\r\"&<"))) ;; (? (group ;; (in "\t\n\r&") ;; (* (not (in "\"<"))))) ;; "\""))) (| (group (* (in "\t\n\r ")) ">") (: (group (* (in "\t\n\r ")) "/") (? (group ">"))) (group (+ (in "\t\n\r ")))))) and the overflow likely occurs somewhere in the ;;-marked section above, while parsing the big d="..." attribute value. That value isn't huge (55 KiB) and in any case our parser clearly shouldn't need stack space in proportional to an XML attribute value. (The default stack limit fails with attributes around 300 KiB in size, which is not big for an SVG file.) Isolated test case: (let ((s (concat "'" (make-string 300000 ?a) "'"))) (string-match (rx "'" (* (not (in "\t\n\r&'<"))) (? (group (in "\t\n\r&") (* (not (in "'<"))))) "'") s)) I suggest you rewrite the attribute parser so that it doesn't eat regexp stack. For instance, (rx "'" (* (not (in "'<"))) "'") doesn't consume stack (thanks to the on_failure_keep_string_jump optimisation). The parser needs to be a little more complex than that and validate entities (the &xyz; things) and detect (and recover from) common errors such as missing end quotes, so a single regexp isn't sufficient. ^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#4175: 23.1; nxml-mode: Internal error in rng-validate-mode triggered 2022-07-10 11:00 ` Mattias Engdegård @ 2022-07-10 13:06 ` Stefan Kangas 0 siblings, 0 replies; 13+ messages in thread From: Stefan Kangas @ 2022-07-10 13:06 UTC (permalink / raw) To: Mattias Engdegård; +Cc: Eli Zaretskii, Stephen Berman, 4175, ahyatt reopen 4175 thanks Mattias Engdegård <mattiase@acm.org> writes: > The bug is still very much there: I can reproduce it by reducing > emacs_re_max_failures from 40000 to 4000. It's just a matter of file > size. The failing regexp (used at xmltok.el:735) is, after rx > conversion, Thanks, I'm therefore reopening this bug. ^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#4175: 23.1; nxml-mode: Internal error in rng-validate-mode triggered @ 2009-08-17 11:59 karme 0 siblings, 0 replies; 13+ messages in thread From: karme @ 2009-08-17 11:59 UTC (permalink / raw) To: bug-gnu-emacs If I try to validate a SVG with a huge path element in nxml-mode I get the error: Internal error in rng-validate-mode triggered at buffer position 616. Stack overflow in regexp matcher. See also debian bug #541260 <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=541260> In GNU Emacs 23.1.1 (x86_64-pc-linux-gnu) of 2009-08-03 on nautilus, modified by Debian configured using `configure '--build=x86_64-linux-gnu' '--host=x86_64-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=no' 'build_alias=x86_64-linux-gnu' 'host_alias=x86_64-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: de_DE.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: nXML Minor modes in effect: server-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: C ESC O C ESC O C ESC O C ESC O C ESC O C ESC O C ESC O C ESC O C ESC O C ESC O C ESC O C ESC O C ESC O C ESC O C ESC O C ESC O C ESC O C ESC O C ESC O C ESC O C i n SPC n x m l - m DEL DEL DEL DEL DEL DEL DEL DEL DEL ESC [ 1 ; 5 C ESC O C i n SPC n x m l - m o d e SPC C-a ESC q ESC O B ESC O B ESC O B ESC O A ESC O A ESC O A ESC O A ESC O A ESC O A ESC O A ESC O A ESC O A ESC O A ESC O B ESC O B ESC O B ESC O B ESC O A C-k C-k C-k C-_ C-_ ESC O B ESC O B ESC O B ESC O B ESC O B ESC O A C-k C-k C-k ESC O A ESC O D . ESC O C ESC O B ESC O B C-x 1 ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC O A ESC O A C-x 2 b b C-_ C-_ ESC O A C-_ C-x b n x TAB DEL DEL t TAB RET ESC x ESC O A RET Recent messages: Error during redisplay: (error Stack overflow in regexp matcher) Making completion list... byte-code: Command attempted to use minibuffer while in minibuffer Internal nXML mode error in nxml-extend-after-change-region (Invalid search bound (wrong side of point)), degrading run-hook-with-args: Wrong type argument: listp, t Undo! [2 times] Mark set [2 times] Auto-saving...done Undo! [4 times] Redo! ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-07-10 13:06 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-12 0:15 bug#4175: 23.1; nxml-mode: Internal error in rng-validate-mode triggered Chong Yidong
[not found] ` <87r5u9r3io.fsf@thialfi.karme.de>
2016-02-12 4:23 ` Andrew Hyatt
2016-02-12 7:19 ` Eli Zaretskii
2016-02-12 10:12 ` Stephen Berman
2016-02-12 12:02 ` Eli Zaretskii
2016-02-12 12:14 ` Stephen Berman
2016-02-12 15:15 ` Eli Zaretskii
2022-07-10 2:53 ` Stefan Kangas
2022-07-10 9:24 ` Stephen Berman
2022-07-10 10:48 ` Stefan Kangas
2022-07-10 11:00 ` Mattias Engdegård
2022-07-10 13:06 ` Stefan Kangas
-- strict thread matches above, loose matches on Subject: below --
2009-08-17 11:59 karme
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).