From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23075: 24.5; vc-git-command should use coding-system-for-read Date: Mon, 21 Mar 2016 21:17:18 +0200 Message-ID: <83bn6763pd.fsf@gnu.org> References: <56EFD97C.3080805@gmail.com> <83wpov6c35.fsf@gnu.org> <87d1qng4aj.fsf@wanadoo.es> <87egb3r9wc.fsf@linux-m68k.org> <83k2kv66bj.fsf@gnu.org> <56F04154.9010405@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1458587905 24169 80.91.229.3 (21 Mar 2016 19:18:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Mar 2016 19:18:25 +0000 (UTC) Cc: 23075@debbugs.gnu.org To: Nikolay Kudryavtsev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 21 20:18:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ai5LB-0000Wf-UF for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 20:18:14 +0100 Original-Received: from localhost ([::1]:59870 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai5L8-0003Ae-3n for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 15:18:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56232) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai5L5-0003AY-4Q for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 15:18:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai5L0-0005W2-Gz for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 15:18:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai5L0-0005Vy-D5 for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 15:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ai5L0-00050f-6z for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 15:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Mar 2016 19:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23075 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23075-submit@debbugs.gnu.org id=B23075.145858787219241 (code B ref 23075); Mon, 21 Mar 2016 19:18:02 +0000 Original-Received: (at 23075) by debbugs.gnu.org; 21 Mar 2016 19:17:52 +0000 Original-Received: from localhost ([127.0.0.1]:57307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai5Kq-00050G-4t for submit@debbugs.gnu.org; Mon, 21 Mar 2016 15:17:52 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai5Ko-000503-HL for 23075@debbugs.gnu.org; Mon, 21 Mar 2016 15:17:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai5Ke-0005Tv-Sa for 23075@debbugs.gnu.org; Mon, 21 Mar 2016 15:17:45 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai5Ke-0005Tr-PJ; Mon, 21 Mar 2016 15:17:40 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3082 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ai5Ke-0004TD-0J; Mon, 21 Mar 2016 15:17:40 -0400 In-reply-to: <56F04154.9010405@gmail.com> (message from Nikolay Kudryavtsev on Mon, 21 Mar 2016 21:45:40 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115262 Archived-At: > From: Nikolay Kudryavtsev > Cc: 23075@debbugs.gnu.org > Date: Mon, 21 Mar 2016 21:45:40 +0300 > > Ok, here are more detailed steps on how to repeat this this bug. > 1. Clone https://github.com/sg2002/vc-git-bugs > 2. Open 1251.txt in windows1251 encoding. Do some changes in it. > 3. vc-diff. This would give you diff with broken encoding. > 4. Evaluate vc-git-command from fix.el in the repo. > 5. vc-diff again, it would give you the correct encoding as long as the > file itself opened correctly. What if the diffs show changes in more than one file? Then the encoding of the file being visited is no longer as relevant as in the use case you describe.