From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24603: [PATCH 0/3] Case table updates Date: Tue, 18 Oct 2016 09:36:31 +0300 Message-ID: <83bmyixixc.fsf@gnu.org> References: <1476741825-32172-1-git-send-email-mina86@mina86.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1476772658 11868 195.159.176.226 (18 Oct 2016 06:37:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Oct 2016 06:37:38 +0000 (UTC) Cc: 24603@debbugs.gnu.org To: Michal Nazarewicz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 18 08:37:34 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwO1R-0008Qt-RX for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Oct 2016 08:37:13 +0200 Original-Received: from localhost ([::1]:39193 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwO1T-0002lT-M0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Oct 2016 02:37:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwO1J-0002lL-KL for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 02:37:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwO1G-0001rI-GT for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 02:37:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59508) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bwO1G-0001rE-D7 for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 02:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bwO1G-0003uj-73 for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 02:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Oct 2016 06:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24603 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24603-submit@debbugs.gnu.org id=B24603.147677262015037 (code B ref 24603); Tue, 18 Oct 2016 06:37:02 +0000 Original-Received: (at 24603) by debbugs.gnu.org; 18 Oct 2016 06:37:00 +0000 Original-Received: from localhost ([127.0.0.1]:37465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwO1D-0003uT-P3 for submit@debbugs.gnu.org; Tue, 18 Oct 2016 02:36:59 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwO1C-0003uG-9W for 24603@debbugs.gnu.org; Tue, 18 Oct 2016 02:36:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwO13-0001oY-V2 for 24603@debbugs.gnu.org; Tue, 18 Oct 2016 02:36:53 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57752) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwO13-0001oU-RR; Tue, 18 Oct 2016 02:36:49 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2806 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bwO13-0002cY-2h; Tue, 18 Oct 2016 02:36:49 -0400 In-reply-to: <1476741825-32172-1-git-send-email-mina86@mina86.com> (message from Michal Nazarewicz on Tue, 18 Oct 2016 00:03:42 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124620 Archived-At: > From: Michal Nazarewicz > Cc: eliz@gnu.org > Date: Tue, 18 Oct 2016 00:03:42 +0200 > > As I continue working on the patchset, it keeps on growing. To > somewhat limit that, I’ll start applying the patches. This is up to you to some degree, but I'd like to point out that it is not necessary to apply patches piecemeal. You can merge to, or rebase on, master everything in one go when you are done, there should be no technical difficulties with that whatsoever. Another potential issue I'd like us to avoid is to modify the same parts of the code several times in related commits. If that happens, I'd prefer a single commit that changes them only once. That said, separate pushes are justified if the parts you push provide self-contained significant features or improvements. > The first two map to the first two from original sumbission. The > first gained tests for byte-8 characters and the second includes > changes requested by Eli. > > The third is a new patch. > > Michal Nazarewicz (3): > Add tests for casefiddle.c > Generate upcase and downcase tables from Unicode data > Don’t generate ‘X maps to X’ entries in case tables Can't the 3rd patch break some code which assumes the current state of affairs, i.e. that the case-table entries for characters with no case variants are identical to the character itself? IOW, this sounds like an incompatible change, so it should be mentioned as such in NEWS, and perhaps we should make sure we don't break too much code out there, not sure if that is possible. What kind of memory savings does this produce, in terms of memory footprint of a running Emacs process? I have no objections or comments to the other 2 patches. Thanks.